From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Hans Schillstrom <hans@schillstrom.com>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Hans Schillstrom <hans.schillstrom@ericsson.com>
Subject: Re: Re[2]: [PATCH 05/19] netfilter: nf_conntrack_ipv6: improve fragmentation handling
Date: Thu, 23 Aug 2012 16:49:20 +0200 [thread overview]
Message-ID: <1345733360.3069.380.camel@localhost> (raw)
In-Reply-To: <alpine.LFD.2.00.1208221014000.1698@ja.ssi.bg>
On Wed, 2012-08-22 at 10:16 +0300, Julian Anastasov wrote:
> Hello,
>
> On Wed, 22 Aug 2012, Julian Anastasov wrote:
>
> > On Wed, 22 Aug 2012, Hans Schillstrom wrote:
> >
> > > >Perhaps we could change/fix the MTU check in IPVS?
> > > >(This would also solve issues I've seen with TSO/GSO frames, hitting
> > > >this code path).
> > > >
> > > I ran into this as well,
> > > try this for the mtu check.
> > >
> > > if ((!skb->local_df && skb->len > mtu && !skb_is_gso(skb)) ||
> > > (IP6CB(skb)->frag_max_size && IP6CB(skb)->frag_max_size > mtu)) {
> >
> > Better without local_df check, it is our job to
> > set it.
Will the IPVS usage of local_df, conflict with Patrick's usage?
> Ops, sorry. It seems now nf_ct_frag6_reasm (Patch 02/18)
> will set head->local_df = 1, so we should check local_df
> as Hans said.
With Hans'es version of the MTU check, IPVS seems to work again (with
Patricks patches applied).
(Also spotted the GSO problem I had with IPv6 + DR, and send an upstream
fix...)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2012-08-23 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 5:01 Re[2]: [PATCH 05/19] netfilter: nf_conntrack_ipv6: improve fragmentation handling Hans Schillstrom
2012-08-22 7:07 ` Julian Anastasov
2012-08-22 7:16 ` Julian Anastasov
2012-08-23 14:49 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345733360.3069.380.camel@localhost \
--to=brouer@redhat.com \
--cc=hans.schillstrom@ericsson.com \
--cc=hans@schillstrom.com \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).