netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Leblond <eric@regit.org>
To: Mr Dash Four <mr.dash.four@googlemail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Netfilter Core Team <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] pgsql: add SSL connection implementation to PGSQL plugin
Date: Mon, 03 Sep 2012 08:33:17 +0200	[thread overview]
Message-ID: <1346653997.5194.37.camel@tiger.regit.org> (raw)
In-Reply-To: <50440A1B.7060908@googlemail.com>

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi,

Le lundi 03 septembre 2012 à 02:38 +0100, Mr Dash Four a écrit :
> > I won't take a patch that fixes a NULL pointer dereference and adds a
> > new feature.
> > 
> > Please, split this in two patches. First fix the bug, then add the new
> > fature.
> Sure. Are there any (other) objections to the patch I submitted?

I've applied the current patch to give it a run. And it shows a lot of
whitespace errors. You'll need to fix it too.

BR,
-- 
Eric Leblond 
Blog: http://home.regit.org/ - Portfolio: http://regit.500px.com/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-09-03  6:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-01 12:51 [PATCH] pgsql: add SSL connection implementation to PGSQL plugin Mr Dash Four
2012-09-02 15:49 ` Eric Leblond
2012-09-02 16:24   ` Mr Dash Four
2012-09-02 23:32 ` Pablo Neira Ayuso
2012-09-03  1:38   ` Mr Dash Four
2012-09-03  6:33     ` Eric Leblond [this message]
2012-09-03 12:00       ` Mr Dash Four
2012-11-07  8:41         ` Eric Leblond
2012-11-10 23:17           ` Mr Dash Four
2012-09-18 19:28     ` Pablo Neira Ayuso
2012-09-20 22:33       ` Mr Dash Four

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346653997.5194.37.camel@tiger.regit.org \
    --to=eric@regit.org \
    --cc=mr.dash.four@googlemail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).