From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: [PATCH net-next] netfilter: x_tables: xt_init() should run earlier Date: Wed, 05 Sep 2012 18:37:53 +0200 Message-ID: <1346863073.13121.155.camel@edumazet-glaptop> References: <1346860506.13121.148.camel@edumazet-glaptop> <1346861569.13121.149.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org, Linux Kernel Network Developers To: Cong Wang , Pablo Neira Ayuso , Patrick McHardy Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:50496 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999Ab2IEQiB (ORCPT ); Wed, 5 Sep 2012 12:38:01 -0400 In-Reply-To: <1346861569.13121.149.camel@edumazet-glaptop> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: Eric Dumazet Cong Wang reported a NULL dereference in xt_register_target() It turns out xt_nat_init() was called before xt_init(), so xt array was not yet setup. xt_init() should be marked core_initcall() to solve this problem. Reported-by: Cong Wang Signed-off-by: Eric Dumazet --- net/netfilter/x_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index 8d987c3..afcea11 100644 --- a/net/netfilter/x_tables.c +++ b/net/netfilter/x_tables.c @@ -1390,6 +1390,6 @@ static void __exit xt_fini(void) kfree(xt); } -module_init(xt_init); +core_initcall(xt_init); module_exit(xt_fini);