From: Simon Horman <horms@verge.net.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
Hans Schillstrom <hans.schillstrom@ericsson.com>,
Hans Schillstrom <hans@schillstrom.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Simon Horman <horms@verge.net.au>
Subject: [PATCH 2/7] ipvs: IPv6 extend ICMPv6 handling for future types
Date: Fri, 28 Sep 2012 11:54:59 +0900 [thread overview]
Message-ID: <1348800904-23902-3-git-send-email-horms@verge.net.au> (raw)
In-Reply-To: <1348800904-23902-1-git-send-email-horms@verge.net.au>
From: Jesper Dangaard Brouer <brouer@redhat.com>
Extend handling of ICMPv6, to all none Informational Messages
(via ICMPV6_INFOMSG_MASK). This actually only extend our handling to
type ICMPV6_PARAMPROB (Parameter Problem), and future types.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
net/netfilter/ipvs/ip_vs_core.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index 4edb654..ebd105c 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -950,9 +950,7 @@ static int ip_vs_out_icmp_v6(struct sk_buff *skb, int *related,
* this means that some packets will manage to get a long way
* down this stack and then be rejected, but that's life.
*/
- if ((ic->icmp6_type != ICMPV6_DEST_UNREACH) &&
- (ic->icmp6_type != ICMPV6_PKT_TOOBIG) &&
- (ic->icmp6_type != ICMPV6_TIME_EXCEED)) {
+ if (ic->icmp6_type & ICMPV6_INFOMSG_MASK) {
*related = 0;
return NF_ACCEPT;
}
@@ -1498,9 +1496,7 @@ ip_vs_in_icmp_v6(struct sk_buff *skb, int *related, unsigned int hooknum)
* this means that some packets will manage to get a long way
* down this stack and then be rejected, but that's life.
*/
- if ((ic->icmp6_type != ICMPV6_DEST_UNREACH) &&
- (ic->icmp6_type != ICMPV6_PKT_TOOBIG) &&
- (ic->icmp6_type != ICMPV6_TIME_EXCEED)) {
+ if (ic->icmp6_type & ICMPV6_INFOMSG_MASK) {
*related = 0;
return NF_ACCEPT;
}
--
1.7.10.4
next prev parent reply other threads:[~2012-09-28 2:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 2:54 [GIT PULL nf-next] IPVS for 3.7 #2 Simon Horman
2012-09-28 2:54 ` [PATCH 1/7] ipvs: Trivial changes, use compressed IPv6 address in output Simon Horman
2012-09-28 2:54 ` Simon Horman [this message]
2012-09-28 2:55 ` [PATCH 3/7] ipvs: Use config macro IS_ENABLED() Simon Horman
2012-09-28 2:55 ` [PATCH 4/7] ipvs: Fix faulty IPv6 extension header handling in IPVS Simon Horman
2012-09-28 2:55 ` [PATCH 5/7] ipvs: Complete IPv6 fragment handling for IPVS Simon Horman
2012-09-28 2:55 ` [PATCH 6/7] ipvs: API change to avoid rescan of IPv6 exthdr Simon Horman
2012-09-28 2:55 ` [PATCH 7/7] ipvs: SIP fragment handling Simon Horman
2012-10-08 18:44 ` [GIT PULL nf-next] IPVS for 3.7 #2 Jesper Dangaard Brouer
2012-10-08 23:17 ` Pablo Neira Ayuso
2012-10-09 3:52 ` Simon Horman
2012-10-22 10:55 ` Pablo Neira Ayuso
2012-10-22 11:53 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348800904-23902-3-git-send-email-horms@verge.net.au \
--to=horms@verge.net.au \
--cc=brouer@redhat.com \
--cc=hans.schillstrom@ericsson.com \
--cc=hans@schillstrom.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).