From: Cong Wang <amwang@redhat.com>
To: netfilter-devel@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>
Subject: Increasing XT_EXTENSION_MAXNAMELEN to 32
Date: Sat, 29 Sep 2012 23:53:49 +0800 [thread overview]
Message-ID: <1348934029.10238.15.camel@cr0> (raw)
Hi, netfilter experts,
A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1
for '\0'), so I just increase it to 32. Do you have any comments or
objections for the following patch?
The vmlinux size increases by 768 bytes with my allyesconfig:
% size vmlinux
text data bss dec hex filename
15158877 3942208 11812864 30913949 1d7b59d vmlinux
% size vmlinux.AFTER
text data bss dec hex filename
15158877 3942976 11812864 30914717 1d7b89d vmlinux.AFTER
I know probably the user-space part needs to update too, here is just
the kernel part patch for you to review. And I only did compile test.
Thanks!
---
diff --git a/include/linux/netfilter/x_tables.h
b/include/linux/netfilter/x_tables.h
index 8d674a7..24b4dd4 100644
--- a/include/linux/netfilter/x_tables.h
+++ b/include/linux/netfilter/x_tables.h
@@ -4,7 +4,7 @@
#include <linux/types.h>
#define XT_FUNCTION_MAXNAMELEN 30
-#define XT_EXTENSION_MAXNAMELEN 29
+#define XT_EXTENSION_MAXNAMELEN 32
#define XT_TABLE_MAXNAMELEN 32
struct xt_entry_match {
next reply other threads:[~2012-09-29 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 15:53 Cong Wang [this message]
2012-09-29 16:46 ` Increasing XT_EXTENSION_MAXNAMELEN to 32 Jan Engelhardt
2012-09-29 18:47 ` Pablo Neira Ayuso
2012-10-02 4:21 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348934029.10238.15.camel@cr0 \
--to=amwang@redhat.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).