From: Cong Wang <amwang@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@inai.de>,
netfilter-devel@vger.kernel.org,
Patrick McHardy <kaber@trash.net>
Subject: Re: Increasing XT_EXTENSION_MAXNAMELEN to 32
Date: Tue, 02 Oct 2012 12:21:33 +0800 [thread overview]
Message-ID: <1349151693.22107.10.camel@cr0> (raw)
In-Reply-To: <20120929184716.GA4050@1984>
On Sat, 2012-09-29 at 20:47 +0200, Pablo Neira Ayuso wrote:
> On Sat, Sep 29, 2012 at 06:46:22PM +0200, Jan Engelhardt wrote:
> > On Saturday 2012-09-29 17:53, Cong Wang wrote:
> >
> > >Hi, netfilter experts,
> > >
> > >A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1
> > >for '\0'), so I just increase it to 32. Do you have any comments or
> > >objections for the following patch?
> >
> > This is a no-no. You are breaking the ABI.
>
> Agreed. Sorry Cong, you cannot do that.
Ok, no problem.
I knew this could break user-space iptables, so there must be some other
applications relying on this ABI too, hmm... I will tell the customer
this is not possible to change.
Thanks!
prev parent reply other threads:[~2012-10-02 4:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 15:53 Increasing XT_EXTENSION_MAXNAMELEN to 32 Cong Wang
2012-09-29 16:46 ` Jan Engelhardt
2012-09-29 18:47 ` Pablo Neira Ayuso
2012-10-02 4:21 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349151693.22107.10.camel@cr0 \
--to=amwang@redhat.com \
--cc=jengelh@inai.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).