From: Julian Anastasov <ja@ssi.bg>
To: netfilter-devel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: [PATCH net] netfilter: nf_conntrack: fix rt_gateway checks for h323
Date: Wed, 10 Oct 2012 02:00:47 +0300 [thread overview]
Message-ID: <1349823647-2166-1-git-send-email-ja@ssi.bg> (raw)
After the change "Adjust semantics of rt->rt_gateway"
(commit f8126f1d51) we should properly match the nexthop when
destinations are directly connected because rt_gateway can be 0.
Signed-off-by: Julian Anastasov <ja@ssi.bg>
---
This patch needs a closer look from the Netfilter team.
It restores the check as it was committed originally,
i.e. to compare nexthops. I'm not sure what is the desired logic,
it can depend on the following:
- two directly connected hosts (rt_gateway=0) can be from different
subnets or not
- one party A is the gateway (rt_gateway=0), another party uses
this gateway (rt_gateway=A)
May be someone that knows this code better can comment
if the check should be different.
net/netfilter/nf_conntrack_h323_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 1b30b0d..962795e 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -753,7 +753,8 @@ static int callforward_do_filter(const union nf_inet_addr *src,
flowi4_to_flowi(&fl1), false)) {
if (!afinfo->route(&init_net, (struct dst_entry **)&rt2,
flowi4_to_flowi(&fl2), false)) {
- if (rt1->rt_gateway == rt2->rt_gateway &&
+ if (rt_nexthop(rt1, fl1.daddr) ==
+ rt_nexthop(rt2, fl2.daddr) &&
rt1->dst.dev == rt2->dst.dev)
ret = 1;
dst_release(&rt2->dst);
--
1.7.3.4
next reply other threads:[~2012-10-09 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 23:00 Julian Anastasov [this message]
2012-10-16 23:55 ` [PATCH net] netfilter: nf_conntrack: fix rt_gateway checks for h323 Pablo Neira Ayuso
2012-10-17 9:03 ` Julian Anastasov
2012-10-17 12:39 ` Pablo Neira Ayuso
2012-10-17 19:44 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349823647-2166-1-git-send-email-ja@ssi.bg \
--to=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).