From: Eric Leblond <eric@regit.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/4] Add configure flag to disable NFLOG build
Date: Sat, 03 Nov 2012 17:02:00 +0100 [thread overview]
Message-ID: <1351958520.11805.2.camel@tourtet> (raw)
In-Reply-To: <alpine.LNX.2.01.1211031541140.14935@nerf07.vanv.qr>
Hi,
Le samedi 03 novembre 2012 à 15:41 +0100, Jan Engelhardt a écrit :
>
> On Saturday 2012-11-03 12:33, Eric Leblond wrote:
> >
> >+if BUILD_NFLOG
> > pkglib_LTLIBRARIES = ulogd_inppkt_NFLOG.la ulogd_inppkt_ULOG.la \
> > ulogd_inppkt_UNIXSOCK.la
> >
> > ulogd_inppkt_NFLOG_la_SOURCES = ulogd_inppkt_NFLOG.c
> > ulogd_inppkt_NFLOG_la_LDFLAGS = -avoid-version -module $(LIBNETFILTER_LOG_LIBS)
> > ulogd_inppkt_NFLOG_la_CFLAGS = $(AM_CFLAGS) $(LIBNETFILTER_LOG_CFLAGS)
> >+else
> >+pkglib_LTLIBRARIES = ulogd_inppkt_ULOG.la ulogd_inppkt_UNIXSOCK.la
> >+endif
>
> You can use
>
> pkglib_LTLIBRARIES = ulogd_inppkt_ULOG.la ulogd_inppkt_UNIXSOCK.la
> if BUILD_NFLOG
> pkglib_LTLIBRARIES += ulogd_inppkt_NFLOG.la
> ...
> endif
>
> So that ulogd_inppkt_ULOG.la ulogd_inppkt_UNIXSOCK.la
> does not have to be listed twice.
You're right that's a better construction.
BR,
--
Eric
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-03 16:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 11:32 [PATCH 0/4] build system improvements Eric Leblond
2012-11-03 11:32 ` [PATCH 1/4] Add configure flag to disable NFACCT build Eric Leblond
2012-11-03 14:40 ` Jan Engelhardt
2012-11-03 16:01 ` Eric Leblond
2012-11-03 16:02 ` Jan Engelhardt
2012-11-03 11:32 ` [PATCH 2/4] Add configure flag to disable NFCT build Eric Leblond
2012-11-03 11:33 ` [PATCH 3/4] Add configure flag to disable NFLOG build Eric Leblond
2012-11-03 14:41 ` Jan Engelhardt
2012-11-03 16:02 ` Eric Leblond [this message]
2012-11-03 11:33 ` [PATCH 4/4] configure: display info about build plugins Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351958520.11805.2.camel@tourtet \
--to=eric@regit.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).