netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] qa: fix handling of ATTR_HELPER_INFO attribute
@ 2012-11-19 21:40 Florian Westphal
  0 siblings, 0 replies; only message in thread
From: Florian Westphal @ 2012-11-19 21:40 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Florian Westphal

The attribute is variable-length and must be thus be set via set_attr_l().

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 I'll push this in a couple of days if noone objects.

 qa/test_api.c |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/qa/test_api.c b/qa/test_api.c
index 92cdafb..3c0f0f9 100644
--- a/qa/test_api.c
+++ b/qa/test_api.c
@@ -83,9 +83,6 @@ int main(void)
 	ret = fork();
 	if (ret == 0) {
 		for (i=0; i<ATTR_MAX; i++) {
-			data[0] = (uint8_t) i;
-			nfct_set_attr(ct, i, data);
-			val = nfct_get_attr(ct, i);
 			/* These attributes cannot be set, ignore them. */
 			switch(i) {
 			case ATTR_ORIG_COUNTER_PACKETS:
@@ -96,8 +93,18 @@ int main(void)
 			case ATTR_SECCTX:
 			case ATTR_TIMESTAMP_START:
 			case ATTR_TIMESTAMP_STOP:
+			case ATTR_CONNLABELS:
 				continue;
+			/* These attributes require special handling */
+			case ATTR_HELPER_INFO:
+				nfct_set_attr_l(ct, i, data, sizeof(data));
+				break;
+			default:
+				data[0] = (uint8_t) i;
+				nfct_set_attr(ct, i, data);
 			}
+			val = nfct_get_attr(ct, i);
+
 			if (val[0] != data[0]) {
 				printf("ERROR: set/get operations don't match "
 				       "for attribute %d (%x != %x)\n",
-- 
1.7.8.6


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-19 21:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 21:40 [PATCH] qa: fix handling of ATTR_HELPER_INFO attribute Florian Westphal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).