From: Eric Leblond <eric@regit.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] build: resolve compile error due to missing nfacct CPPFLAGS
Date: Tue, 27 Nov 2012 08:54:35 +0100 [thread overview]
Message-ID: <1354002875.4103.5.camel@tiger2> (raw)
In-Reply-To: <1353974099-19891-3-git-send-email-jengelh@inai.de>
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
Hello,
On Tue, 2012-11-27 at 00:54 +0100, Jan Engelhardt wrote:
> Fixes this error:
>
> make[3]: Entering directory "/home/jengelh/code/ulogd2/output"
> CC ulogd_output_XML.lo
> ulogd_output_XML.c:31:49: fatal error:
> libnetfilter_acct/libnetfilter_acct.h: No such file or directory
>
> (Note that pkgconfig-provided cflags are actually cppflags, so
> I add ${LIBNETFILTER_ACCT_CFLAGS} to AM_CPPFLAGS.)
>
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> output/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/output/Makefile.am b/output/Makefile.am
> index 630aee6..61d827a 100644
> --- a/output/Makefile.am
> +++ b/output/Makefile.am
> @@ -1,4 +1,4 @@
> -AM_CPPFLAGS = -I$(top_srcdir)/include
> +AM_CPPFLAGS = -I$(top_srcdir)/include ${LIBNETFILTER_ACCT_CFLAGS}
> AM_CFLAGS = ${regular_CFLAGS} ${LIBNETFILTER_LOG_CFLAGS} \
> ${LIBNETFILTER_CONNTRACK_CFLAGS}
Good catch but on last line we use the other ${LIBNETFILTER*_CFLAGS} to
populate AM_CFLAGS. We should keep all variables at the same place. If
we follow your indication in the commit we should use AM_CPPFLAGS (I'm
agree with that).
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-27 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 23:54 ulogd fixes Jan Engelhardt
2012-11-26 23:54 ` [PATCH 1/2] build: resolve automake-1.12 warnings Jan Engelhardt
2012-11-27 7:56 ` Eric Leblond
2012-11-26 23:54 ` [PATCH 2/2] build: resolve compile error due to missing nfacct CPPFLAGS Jan Engelhardt
2012-11-27 7:54 ` Eric Leblond [this message]
2012-11-27 11:51 ` Jan Engelhardt
2012-11-27 12:30 ` Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354002875.4103.5.camel@tiger2 \
--to=eric@regit.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).