From: Eric Leblond <eric@regit.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] build: resolve compile error due to missing nfacct CPPFLAGS
Date: Tue, 27 Nov 2012 13:30:08 +0100 [thread overview]
Message-ID: <1354019408.4103.10.camel@tiger2> (raw)
In-Reply-To: <alpine.LNX.2.01.1211271251000.22381@nerf07.vanv.qr>
Hi,
On Tue, 2012-11-27 at 12:51 +0100, Jan Engelhardt wrote:
> On Tuesday 2012-11-27 08:54, Eric Leblond wrote:
> >> index 630aee6..61d827a 100644
> >> --- a/output/Makefile.am
> >> +++ b/output/Makefile.am
> >> @@ -1,4 +1,4 @@
> >> -AM_CPPFLAGS = -I$(top_srcdir)/include
> >> +AM_CPPFLAGS = -I$(top_srcdir)/include ${LIBNETFILTER_ACCT_CFLAGS}
> >> AM_CFLAGS = ${regular_CFLAGS} ${LIBNETFILTER_LOG_CFLAGS} \
> >> ${LIBNETFILTER_CONNTRACK_CFLAGS}
> >
> >Good catch but on last line we use the other ${LIBNETFILTER*_CFLAGS} to
> >populate AM_CFLAGS. We should keep all variables at the same place. If
> >we follow your indication in the commit we should use AM_CPPFLAGS (I'm
> >agree with that).
>
> I can send another patch moving all the pkgconfig variables to
> CPPFLAGS.
Please do, I will push your two patches to the public tree once done.
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
prev parent reply other threads:[~2012-11-27 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 23:54 ulogd fixes Jan Engelhardt
2012-11-26 23:54 ` [PATCH 1/2] build: resolve automake-1.12 warnings Jan Engelhardt
2012-11-27 7:56 ` Eric Leblond
2012-11-26 23:54 ` [PATCH 2/2] build: resolve compile error due to missing nfacct CPPFLAGS Jan Engelhardt
2012-11-27 7:54 ` Eric Leblond
2012-11-27 11:51 ` Jan Engelhardt
2012-11-27 12:30 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354019408.4103.10.camel@tiger2 \
--to=eric@regit.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).