netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Leblond <eric@regit.org>
To: netfilter-devel@vger.kernel.org
Cc: eric@regit.org
Subject: [PATCH 2/7] Suppress dead FIXME.
Date: Mon, 18 Feb 2013 09:37:43 +0100	[thread overview]
Message-ID: <1361176668-22661-3-git-send-email-eric@regit.org> (raw)
In-Reply-To: <1361176668-22661-1-git-send-email-eric@regit.org>


Signed-off-by: Eric Leblond <eric@regit.org>
---
 input/packet/ulogd_inppkt_NFLOG.c |    2 --
 src/ulogd.c                       |    1 -
 2 files changed, 3 deletions(-)

diff --git a/input/packet/ulogd_inppkt_NFLOG.c b/input/packet/ulogd_inppkt_NFLOG.c
index 7870c31..cc0c2d4 100644
--- a/input/packet/ulogd_inppkt_NFLOG.c
+++ b/input/packet/ulogd_inppkt_NFLOG.c
@@ -339,7 +339,6 @@ interp_packet(struct ulogd_pluginstance *upi, u_int8_t pf_family,
 		    label_ce(upi->config_kset).u.value);
 
 	if (ph) {
-		/* FIXME */
 		okey_set_u8(&ret[NFLOG_KEY_OOB_HOOK], ph->hook);
 		okey_set_u16(&ret[NFLOG_KEY_OOB_PROTOCOL],
 			     ntohs(ph->hw_protocol));
@@ -376,7 +375,6 @@ interp_packet(struct ulogd_pluginstance *upi, u_int8_t pf_family,
 	if (! (nflog_get_timestamp(ldata, &ts) == 0 && ts.tv_sec))
 		gettimeofday(&ts, NULL);
 
-	/* FIXME: convert endianness */
 	okey_set_u32(&ret[NFLOG_KEY_OOB_TIME_SEC], ts.tv_sec & 0xffffffff);
 	okey_set_u32(&ret[NFLOG_KEY_OOB_TIME_USEC], ts.tv_usec & 0xffffffff);
 
diff --git a/src/ulogd.c b/src/ulogd.c
index d0fdcc5..c7617d9 100644
--- a/src/ulogd.c
+++ b/src/ulogd.c
@@ -1102,7 +1102,6 @@ static void signal_handler(int signal)
 
 static void print_usage(void)
 {
-	/* FIXME */
 	printf("ulogd Version %s\n", VERSION);
 	printf(COPYRIGHT);
 	printf("This is free software with ABSOLUTELY NO WARRANTY.\n\n");
-- 
1.7.10.4


  parent reply	other threads:[~2013-02-18  8:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  8:37 [ulogd patch] small code cleaning Eric Leblond
2013-02-18  8:37 ` [PATCH 1/7] Update TODO Eric Leblond
2013-02-18  8:37 ` Eric Leblond [this message]
2013-02-18  8:37 ` [PATCH 3/7] Use access to ensure readability of config gile Eric Leblond
2013-02-18  8:37 ` [PATCH 4/7] Fix typo in comments Eric Leblond
2013-02-18  8:37 ` [PATCH 5/7] Add handling of too long arguments Eric Leblond
2013-02-18  9:41   ` Mr Dash Four
2013-02-18 15:04     ` Eric Leblond
2013-02-18  8:37 ` [PATCH 6/7] logemu: return error if configuration is invalid Eric Leblond
2013-02-18  8:37 ` [PATCH 7/7] conf: error handling for too long line Eric Leblond
2013-02-18  9:41   ` Mr Dash Four
2013-02-22 10:18 ` [ulogd patch] small code cleaning Eric Leblond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361176668-22661-3-git-send-email-eric@regit.org \
    --to=eric@regit.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).