From: pablo@netfilter.org
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 2/7] netfilter: nfnetlink_queue: fix incorrect initialization of copy range field
Date: Wed, 20 Mar 2013 11:49:29 +0100 [thread overview]
Message-ID: <1363776574-4766-3-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1363776574-4766-1-git-send-email-pablo@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
2^16 = 0xffff, not 0xfffff (note the extra 'f'). Not dangerous since you
adjust it to min_t(data_len, skb->len) just after on.
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nfnetlink_queue_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index 858fd52..1cb4854 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -112,7 +112,7 @@ instance_create(u_int16_t queue_num, int portid)
inst->queue_num = queue_num;
inst->peer_portid = portid;
inst->queue_maxlen = NFQNL_QMAX_DEFAULT;
- inst->copy_range = 0xfffff;
+ inst->copy_range = 0xffff;
inst->copy_mode = NFQNL_COPY_NONE;
spin_lock_init(&inst->lock);
INIT_LIST_HEAD(&inst->queue_list);
--
1.7.10.4
next prev parent reply other threads:[~2013-03-20 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 10:49 [PATCH 0/7] netfilter fixes for 3.9-rc pablo
2013-03-20 10:49 ` [PATCH 1/7] netfilter: nf_conntrack: register pernet subsystem before register L4 proto pablo
2013-03-20 10:49 ` pablo [this message]
2013-03-20 13:33 ` [PATCH 2/7] netfilter: nfnetlink_queue: fix incorrect initialization of copy range field Sergei Shtylyov
2013-03-20 10:49 ` [PATCH 3/7] netfilter: ip6t_NPT: restrict to mangle table pablo
2013-03-20 10:49 ` [PATCH 4/7] ipvs: fix sctp chunk length order pablo
2013-03-20 10:49 ` [PATCH 5/7] ipvs: add backup_only flag to avoid loops pablo
2013-03-20 10:49 ` [PATCH 6/7] ipvs: remove extra rcu lock pablo
2013-03-20 10:49 ` [PATCH 7/7] netfilter: remove unused "config IP_NF_QUEUE" pablo
2013-03-20 14:25 ` [PATCH 0/7] netfilter fixes for 3.9-rc David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363776574-4766-3-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).