netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netfilter: xt_osf: fix inversion
@ 2013-03-24 10:34 pablo
  0 siblings, 0 replies; only message in thread
From: pablo @ 2013-03-24 10:34 UTC (permalink / raw)
  To: netfilter-devel

From: Pablo Neira Ayuso <pablo@netfilter.org>

-m osf --genre Windows
-m osf ! --genre Windows

are both matching.

Reported-by: Reported-by: Bourne Without <blackhole@airpost.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/xt_osf.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c
index a5e673d..110c848 100644
--- a/net/netfilter/xt_osf.c
+++ b/net/netfilter/xt_osf.c
@@ -201,6 +201,7 @@ xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
 	unsigned char opts[MAX_IPOPTLEN];
 	const struct xt_osf_finger *kf;
 	const struct xt_osf_user_finger *f;
+	bool invert = info->flags & XT_OSF_INVERT;
 
 	if (!info)
 		return false;
@@ -349,7 +350,7 @@ xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
 	if (fcount)
 		fmatch = FMATCH_OK;
 
-	return fmatch == FMATCH_OK;
+	return (fmatch == FMATCH_OK) ^ invert;
 }
 
 static struct xt_match xt_osf_match = {
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-03-24 10:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-24 10:34 [PATCH] netfilter: xt_osf: fix inversion pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).