netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
	David Miller <davem@davemloft.net>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org,
	Wensong Zhang <wensong@linux-vs.org>,
	Julian Anastasov <ja@ssi.bg>, Simon Horman <horms@verge.net.au>
Subject: [PATCH 03/15] ipvs: prefer NETDEV_DOWN event to free cached dsts
Date: Thu, 28 Mar 2013 14:39:32 +0900	[thread overview]
Message-ID: <1364449184-26672-4-git-send-email-horms@verge.net.au> (raw)
In-Reply-To: <1364449184-26672-1-git-send-email-horms@verge.net.au>

From: Julian Anastasov <ja@ssi.bg>

The real server becomes unreachable on down event,
no need to wait device unregistration. Should help in
releasing dsts early before dst->dev is replaced with lo.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off by: Hans Schillstrom <hans@schillstrom.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 net/netfilter/ipvs/ip_vs_ctl.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index a528178..2af8074 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -1514,10 +1514,8 @@ __ip_vs_dev_reset(struct ip_vs_dest *dest, struct net_device *dev)
 	spin_unlock_bh(&dest->dst_lock);
 
 }
-/*
- * Netdev event receiver
- * Currently only NETDEV_UNREGISTER is handled, i.e. if we hold a reference to
- * a device that is "unregister" it must be released.
+/* Netdev event receiver
+ * Currently only NETDEV_DOWN is handled to release refs to cached dsts
  */
 static int ip_vs_dst_event(struct notifier_block *this, unsigned long event,
 			    void *ptr)
@@ -1529,7 +1527,7 @@ static int ip_vs_dst_event(struct notifier_block *this, unsigned long event,
 	struct ip_vs_dest *dest;
 	unsigned int idx;
 
-	if (event != NETDEV_UNREGISTER || !ipvs)
+	if (event != NETDEV_DOWN || !ipvs)
 		return NOTIFY_DONE;
 	IP_VS_DBG(3, "%s() dev=%s\n", __func__, dev->name);
 	EnterFunction(2);
-- 
1.7.10.4


  parent reply	other threads:[~2013-03-28  5:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  5:39 [PATCH 00/15 v3] IPVS optimizations (repost) Simon Horman
2013-03-28  5:39 ` [PATCH 01/15] net: add skb_dst_set_noref_force Simon Horman
2013-03-28  5:39 ` [PATCH 02/15] ipvs: avoid routing by TOS for real server Simon Horman
2013-03-28  5:39 ` Simon Horman [this message]
2013-03-28  5:39 ` [PATCH 04/15] ipvs: convert the IP_VS_XMIT macros to functions Simon Horman
2013-03-28  5:39 ` [PATCH 05/15] ipvs: rename functions related to dst_cache reset Simon Horman
2013-03-28  5:39 ` [PATCH 06/15] ipvs: no need to reroute anymore on DNAT over loopback Simon Horman
2013-03-28  5:39 ` [PATCH 07/15] ipvs: do not use skb_share_check Simon Horman
2013-03-28  5:39 ` [PATCH 08/15] ipvs: consolidate all dst checks on transmit in one place Simon Horman
2013-03-28  5:39 ` [PATCH 09/15] ipvs: optimize dst usage for real server Simon Horman
2013-03-28  5:39 ` [PATCH 10/15] ipvs: convert app locks Simon Horman
2013-03-28  5:39 ` [PATCH 11/15] ipvs: remove rs_lock by using RCU Simon Horman
2013-03-28  5:39 ` [PATCH 12/15] ipvs: convert locks used in persistence engines Simon Horman
2013-03-28  5:39 ` [PATCH 13/15] ipvs: convert connection locking Simon Horman
2013-03-28  5:39 ` [PATCH 14/15] ipvs: reorder keys in connection structure Simon Horman
2013-03-28  5:39 ` [PATCH 15/15] ipvs: avoid kmem_cache_zalloc in ip_vs_conn_new Simon Horman
2013-03-28  9:04 ` [PATCH 00/15 v3] IPVS optimizations (repost) Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364449184-26672-4-git-send-email-horms@verge.net.au \
    --to=horms@verge.net.au \
    --cc=davem@davemloft.net \
    --cc=ja@ssi.bg \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).