From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH -next 0/5] netfilter: nf_queue: avoid expensive gso/checksumming
Date: Tue, 16 Apr 2013 17:32:03 +0200 [thread overview]
Message-ID: <1366126328-25874-1-git-send-email-fw@strlen.de> (raw)
Hi Pablo,
please consider pulling from
git://git.breakpoint.cc/fw/nf-next.git nfqueue_gso_avoidance_04
to retrieve the following changes since commit aaa795ad25e18488b026572c7ba2ca8f99ced0b7:
netfilter: nat: propagate errors from xfrm_me_harder() (2013-04-08 12:34:01 +0200)
Florian Westphal (5):
netfilter: nf_queue: move device refcount bump to extra function
netfilter: nfnetlink_queue: avoid peer_portid test
netfilter: move skb_gso_segment into nfnetlink_queue module
netfilter: nfnetlink_queue: add skb info attribute
netfilter: nfqueue: avoid expensive gso segmentation and checksum fixup
With these patches, userspace can now instruct the kernel that it is gso/gro
aware and can handle "invalid" checksums that appear in packet headers.
For old userspace, nothing is changed: the kernel segments gso skbs
and adjusts checksums.
To avoid gso/checksum fixup overhead, userspace applications must set the
new NFQA_CFG_F_GSO config flag via NFQA_CFG_FLAGS attribute AND
check the new NFQA_SKB_INFO attribute when processing a packet.
This new attribute currently contains two bits:
- NFQA_SKB_CSUMNOTREADY means 'checksums will be fixed in kernel
later, pretend they are ok'.
- NFQA_SKB_GSO could be used for statistics, or to determine when
packet size exceeds mtu.
I've done a few tests with old userspace and did not notice any issues.
Feedback welcome.
Update for libnetfilter_queue (including example program/documentation)
will follow later.
diffstat:
include/net/netfilter/nf_queue.h | 6 +
include/uapi/linux/netfilter/nfnetlink_queue.h | 10 ++-
net/netfilter/nf_queue.c | 143 +++++---------------
net/netfilter/nfnetlink_queue_core.c | 169 ++++++++++++++++++++---
4 files changed, 198 insertions(+), 130 deletions(-)
next reply other threads:[~2013-04-16 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:32 Florian Westphal [this message]
2013-04-16 15:32 ` [PATCH 1/5] netfilter: nf_queue: move device refcount bump to extra function Florian Westphal
2013-04-16 15:32 ` [PATCH 2/5] netfilter: nfnetlink_queue: avoid peer_portid test Florian Westphal
2013-04-16 15:32 ` [PATCH 3/5] netfilter: move skb_gso_segment into nfnetlink_queue module Florian Westphal
2013-04-16 15:32 ` [PATCH 4/5] netfilter: nfnetlink_queue: add skb info attribute Florian Westphal
2013-04-16 15:55 ` Eric Dumazet
2013-04-16 17:47 ` Florian Westphal
2013-04-16 15:32 ` [PATCH 5/5] netfilter: nfqueue: avoid expensive gso segmentation and checksum fixup Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366126328-25874-1-git-send-email-fw@strlen.de \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).