From: Simon Horman <horms@verge.net.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
Dan Carpenter <dan.carpenter@oracle.com>,
Simon Horman <horms@verge.net.au>
Subject: [PATCH nf-next 6/9] ipvs: Avoid shadowing net variable in ip_vs_leave()
Date: Tue, 23 Apr 2013 12:03:57 +0900 [thread overview]
Message-ID: <1366686240-23493-7-git-send-email-horms@verge.net.au> (raw)
In-Reply-To: <1366686240-23493-1-git-send-email-horms@verge.net.au>
Flagged by sparse.
Compile and sparse tested only.
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
net/netfilter/ipvs/ip_vs_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index a0d7bd3..085b588 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -584,9 +584,9 @@ int ip_vs_leave(struct ip_vs_service *svc, struct sk_buff *skb,
#ifdef CONFIG_IP_VS_IPV6
if (svc->af == AF_INET6) {
if (!skb->dev) {
- struct net *net = dev_net(skb_dst(skb)->dev);
+ struct net *net_ = dev_net(skb_dst(skb)->dev);
- skb->dev = net->loopback_dev;
+ skb->dev = net_->loopback_dev;
}
icmpv6_send(skb, ICMPV6_DEST_UNREACH, ICMPV6_PORT_UNREACH, 0);
} else
--
1.8.2.1
next prev parent reply other threads:[~2013-04-23 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 3:03 [GIT PULL nf-next v2] IPVS fixes for v3.10 Simon Horman
2013-04-23 3:03 ` [PATCH nf-next 1/9] ipvs: properly dereference dest_dst in ip_vs_forget_dev Simon Horman
2013-04-23 3:03 ` [PATCH nf-next 2/9] ipvs: fix sparse warnings for ip_vs_conn listing Simon Horman
2013-04-23 3:03 ` [PATCH nf-next 3/9] ipvs: fix the remaining sparse warnings in ip_vs_ctl.c Simon Horman
2013-04-23 3:03 ` [PATCH nf-next 4/9] ipvs: fix sparse warnings in lblc and lblcr Simon Horman
2013-04-23 3:03 ` [PATCH nf-next 5/9] ipvs: fix sparse warnings for some parameters Simon Horman
2013-04-23 3:03 ` Simon Horman [this message]
2013-04-23 3:03 ` [PATCH nf-next 7/9] ipvs: Use min3() in ip_vs_dbg_callid() Simon Horman
2013-04-23 3:03 ` [PATCH nf-next 8/9] ipvs: off by one in set_sctp_state() Simon Horman
2013-04-23 3:04 ` [PATCH nf-next 9/9] ipvs: Use network byte order for sync message size Simon Horman
2013-04-24 23:42 ` [GIT PULL nf-next v2] IPVS fixes for v3.10 Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366686240-23493-7-git-send-email-horms@verge.net.au \
--to=horms@verge.net.au \
--cc=dan.carpenter@oracle.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).