From: Hans Schillstrom <hans@schillstrom.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, gaofeng@cn.fujitsu.com,
fw@strlen.de, ronald645@gmail.com
Subject: Re: [PATCH] netfilter: log: netns NULL ptr bug when calling from conntrack.
Date: Wed, 15 May 2013 14:13:49 +0200 [thread overview]
Message-ID: <1368620029.3169.302.camel@hawk.mlab.se> (raw)
In-Reply-To: <20130515120013.GA20074@localhost>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
Hi Pablo,
On Wed, 2013-05-15 at 14:00 +0200, Pablo Neira Ayuso wrote:
> Hi Hans,
>
> On Wed, May 15, 2013 at 01:23:45PM +0200, Hans Schillstrom wrote:
> > When callling log functions from conntrack both in and out
> > is NULL i.e. there exist no net pointer.
> >
> > Adding struct net *net in call to nf_logfn() will secure that
> > there always is a vaild net ptr.
> >
> > Reported as bugzilla bug 818
>
> This approach to fix it looks good. Thanks a lot!
>
> Just resolved a minor nitpick:
[snip]
..
> >
> > static void
> > -ebt_log_packet(u_int8_t pf, unsigned int hooknum,
> > +ebt_log_packet(struct net *net, int8_t pf, unsigned int hooknum,
>
> pf still has to be u_int8_t so I don't hit a compilation warning. No
> need to resent I fixed it here.
Thanks,
I must have pressed "del" to hard :-)
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6177 bytes --]
next prev parent reply other threads:[~2013-05-15 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 11:23 [PATCH] netfilter: log: netns NULL ptr bug when calling from conntrack Hans Schillstrom
2013-05-15 12:00 ` Pablo Neira Ayuso
2013-05-15 12:13 ` Hans Schillstrom [this message]
2013-05-17 9:57 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368620029.3169.302.camel@hawk.mlab.se \
--to=hans@schillstrom.com \
--cc=fw@strlen.de \
--cc=gaofeng@cn.fujitsu.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ronald645@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).