From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Tom Herbert <therbert@google.com>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central spinlock
Date: Wed, 22 May 2013 11:20:16 -0700 [thread overview]
Message-ID: <1369246816.2143.84.camel@joe-AO722> (raw)
In-Reply-To: <1369244868.3301.343.camel@edumazet-glaptop>
On Wed, 2013-05-22 at 10:47 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> nf_conntrack_lock is a monolithic lock and suffers from huge contention
> on current generation servers (8 or more core/threads).
[]
> diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h
[]
> @@ -76,7 +76,8 @@ struct nf_conn {
> plus 1 for any connection(s) we are `master' for */
> struct nf_conntrack ct_general;
>
> - spinlock_t lock;
> + spinlock_t lock;
> + u16 cpu;
trivia:
What's the real value in not using int here?
next prev parent reply other threads:[~2013-05-22 18:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 3:04 [PATCH nf-next] netfilter: conntrack: remove the central spinlock Eric Dumazet
2013-05-09 5:43 ` Cong Wang
2013-05-09 6:01 ` Eric Dumazet
2013-05-09 7:46 ` Cong Wang
2013-05-09 13:46 ` Eric Dumazet
2013-05-22 17:47 ` [PATCH v2 " Eric Dumazet
2013-05-22 18:20 ` Joe Perches [this message]
2013-05-22 19:26 ` Eric Dumazet
2013-05-22 19:57 ` Joe Perches
2013-05-22 20:16 ` Eric Dumazet
2013-05-22 20:38 ` Joe Perches
2013-05-22 20:48 ` Eric Dumazet
2013-05-22 21:12 ` Joe Perches
2013-05-22 21:29 ` David Miller
2013-05-22 21:34 ` Eric Dumazet
2013-05-24 13:16 ` Jesper Dangaard Brouer
2013-05-24 13:51 ` Eric Dumazet
2013-05-27 12:33 ` Jesper Dangaard Brouer
2013-05-27 12:36 ` Pablo Neira Ayuso
2013-08-23 14:42 ` Jesper Dangaard Brouer
2013-08-26 22:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369246816.2143.84.camel@joe-AO722 \
--to=joe@perches.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).