From: Michael Zintakis <michael.zintakis@googlemail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [PATCH v3 nfacct 15/29] add "show bytes" option to "list" and "get" commands
Date: Wed, 10 Jul 2013 19:25:13 +0100 [thread overview]
Message-ID: <1373480727-11254-16-git-send-email-michael.zintakis@googlemail.com> (raw)
In-Reply-To: <1373480727-11254-1-git-send-email-michael.zintakis@googlemail.com>
* add a new "show bytes" option to the "list" and get commands, allowing only
the byte counter column (in addition to nfacct name) to be shown.
Signed-off-by: Michael Zintakis <michael.zintakis@googlemail.com>
---
src/nfacct.c | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/src/nfacct.c b/src/nfacct.c
index 3eb8b68..3f25334 100644
--- a/src/nfacct.c
+++ b/src/nfacct.c
@@ -262,7 +262,7 @@ err:
static int nfacct_cmd_list(int argc, char *argv[])
{
bool nfnl_msg = false, xml = false;
- bool b_fmt = false, b_sort = false;
+ bool b_fmt = false, b_sh = false, b_sort = false;
struct mnl_socket *nl;
char buf[70000];
struct nlmsghdr *nlh;
@@ -271,6 +271,7 @@ static int nfacct_cmd_list(int argc, char *argv[])
struct nfa *nfa = NULL;
uint8_t nfnl_cmd = NFNL_MSG_ACCT_GET;
uint16_t fmt = NFACCT_FMT_MAX;
+ uint16_t flags = NFACCT_SNPRINTF_F_FULL;
enum nfacct_sort_mode sort_mode = NFACCT_SORT_NAME;
while (argc > 0) {
@@ -279,6 +280,14 @@ static int nfacct_cmd_list(int argc, char *argv[])
nfnl_msg = true;
} else if (!xml && nfacct_matches(argv[0],"xml")) {
xml = true;
+ } else if (!b_sh && nfacct_matches(argv[0],"show")) {
+ NFACCT_GET_NEXT_ARG();
+ if (nfacct_matches(argv[0],"bytes")) {
+ flags = NFACCT_SNPRINTF_F_BONLY;
+ } else {
+ NFACCT_RET_ARG_ERR();
+ }
+ b_sh = true;
} else if (!b_sort && nfacct_matches(argv[0],"sort")) {
NFACCT_GET_NEXT_ARG();
if (nfacct_matches(argv[0],"name")) {
@@ -355,7 +364,7 @@ static int nfacct_cmd_list(int argc, char *argv[])
nfa->nfacct,
xml ? NFACCT_SNPRINTF_T_XML :
NFACCT_SNPRINTF_T_PLAIN,
- NFACCT_SNPRINTF_F_FULL, options);
+ flags, options);
printf("%s\n",buf);
}
@@ -534,7 +543,7 @@ static int nfacct_cmd_delete(int argc, char *argv[])
static int nfacct_cmd_get(int argc, char *argv[])
{
bool nfnl_msg = false, xml = false;
- bool b_fmt = false;
+ bool b_sh = false, b_fmt = false;
struct mnl_socket *nl;
char buf[MNL_SOCKET_BUFFER_SIZE];
struct nlmsghdr *nlh;
@@ -545,6 +554,7 @@ static int nfacct_cmd_get(int argc, char *argv[])
char *name;
uint8_t nfnl_cmd = NFNL_MSG_ACCT_GET;
uint16_t fmt = NFACCT_FMT_MAX;
+ uint16_t flags = NFACCT_SNPRINTF_F_FULL;
if (argc < 1 || strlen(argv[0]) == 0) {
nfacct_perror("missing object name");
@@ -562,6 +572,14 @@ static int nfacct_cmd_get(int argc, char *argv[])
nfnl_msg = true;
} else if (!xml && nfacct_matches(argv[0],"xml")) {
xml = true;
+ } else if (!b_sh && nfacct_matches(argv[0],"show")) {
+ NFACCT_GET_NEXT_ARG();
+ if (nfacct_matches(argv[0],"bytes")) {
+ flags = NFACCT_SNPRINTF_F_BONLY;
+ } else {
+ NFACCT_RET_ARG_ERR();
+ }
+ b_sh = true;
} else if (!b_fmt && (nfacct_matches(argv[0],"format") ||
nfacct_matches(argv[0],"fmt"))) {
NFACCT_GET_NEXT_ARG();
@@ -630,7 +648,7 @@ static int nfacct_cmd_get(int argc, char *argv[])
nfa->nfacct,
xml ? NFACCT_SNPRINTF_T_XML :
NFACCT_SNPRINTF_T_PLAIN,
- NFACCT_SNPRINTF_F_FULL, options);
+ flags, options);
printf("%s\n",buf);
}
@@ -729,9 +747,10 @@ static const char help_msg[] =
" version\t\tDisplay version and disclaimer\n"
" help\t\t\tDisplay this help message\n\n"
"Parameters:\n"
- " LST_PARAMS := [ reset ] [ format FMT_SPEC ] [ sort SORT_SPEC ] [ xml ]\n"
+ " LST_PARAMS := [ reset ] [ show bytes ] [ format FMT_SPEC ]\n"
+ "\t\t[ sort SORT_SPEC ] [ xml ]\n"
" ADD_PARAMS := [ replace ]\n"
- " GET_PARAMS := [ reset ] [ format FMT_SPEC ] [ xml ]\n"
+ " GET_PARAMS := [ reset ] [ show bytes ] [ format FMT_SPEC ] [ xml ]\n"
" RST_PARAMS := [ flush ] [ replace ]\n"
" FMT_SPEC := { [FMT] | [,] | [FMT] ... }\n"
" SORT_SPEC := { none | name | packets | bytes }"
--
1.8.3.1
next prev parent reply other threads:[~2013-07-10 18:26 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 18:24 [PATCH v3 0/29] nfacct changes and additions Michael Zintakis
2013-07-10 18:24 ` [PATCH v3 kernel 1/29] bugfix: pkts/bytes need to be specified simultaneously Michael Zintakis
2013-07-10 20:04 ` Florian Westphal
2013-07-11 18:56 ` Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 kernel 2/29] bugfix: restore pkts/bytes counters in NLM_F_REPLACE Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 3/29] bugfix: correct xml name parsing Michael Zintakis
2013-07-15 22:24 ` Pablo Neira Ayuso
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 4/29] bugfix: correct (plain) " Michael Zintakis
2013-07-15 22:29 ` Pablo Neira Ayuso
2013-07-10 18:25 ` [PATCH v3 nfacct 5/29] bugfix: prevent 0-sized parameter being accepted Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 6/29] bugfix: prevent 0-sized nfacct name " Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 7/29] code-refactoring changes to the "command menu" Michael Zintakis
2013-07-15 22:41 ` Pablo Neira Ayuso
2013-07-10 18:25 ` [PATCH v3 nfacct 8/29] add 2 new options: "replace" and "flush" Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 9/29] add *_SAVE template allowing save/restore Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 10/29] add *_BONLY template to show bytes-only Michael Zintakis
2013-07-15 22:42 ` Pablo Neira Ayuso
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 11/29] add variable width and on-the-fly formatting Michael Zintakis
2013-07-15 22:51 ` Pablo Neira Ayuso
2013-07-10 18:25 ` [PATCH v3 nfacct 12/29] add variable width and on-the-fly number formatting Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 13/29] add new "save" and correct existing "restore" commands Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 14/29] add sort option to the "list" command Michael Zintakis
2013-07-10 18:25 ` Michael Zintakis [this message]
2013-07-10 18:25 ` [PATCH v3 kernel 16/29] add permanent byte/packet format capability to nfacct Michael Zintakis
2013-07-10 20:00 ` Florian Westphal
2013-07-11 18:56 ` Michael Zintakis
2013-07-11 20:12 ` Florian Westphal
2013-07-14 8:29 ` Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 17/29] add *permanent* number formatting support Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 18/29] add permanent number formatting to nfacct objects Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 kernel 19/29] add byte threshold capability to nfacct Michael Zintakis
2013-07-10 20:00 ` Florian Westphal
2013-07-11 18:56 ` Michael Zintakis
2013-07-11 20:25 ` Florian Westphal
2013-07-17 19:44 ` Alexey Perevalov
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 20/29] add byte threshold capability support Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 21/29] add byte threshold capabilities to nfacct objects Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 22/29] add *_EXTENDED template support Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 23/29] add "show extended" option to "list" and "get" commands Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 kernel 24/29] add packets and bytes mark capability to nfacct Michael Zintakis
2013-07-10 20:01 ` Florian Westphal
2013-07-11 18:56 ` Michael Zintakis
2013-07-11 1:14 ` Pablo Neira Ayuso
2013-07-11 18:56 ` Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 25/29] add packets/bytes mark capability support Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 26/29] add setmark and clrmark to "get" and "list" commands Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 libnetfilter_acct 27/29] add *_MONLY template support Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 28/29] add "show marks" option to "list" and "get" commands Michael Zintakis
2013-07-10 18:25 ` [PATCH v3 nfacct 29/29] change man page to describe all new features Michael Zintakis
2013-07-15 12:36 ` [0/29] nfacct changes and additions Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373480727-11254-16-git-send-email-michael.zintakis@googlemail.com \
--to=michael.zintakis@googlemail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).