* [PATCH] build: fail in configure on missing dependency for optional component
@ 2013-07-22 0:02 Willem de Bruijn
2013-07-26 14:33 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Willem de Bruijn @ 2013-07-22 0:02 UTC (permalink / raw)
To: pablo, netfilter-devel; +Cc: Willem de Bruijn
The build of utils/nfbpf_compile depends on libpcap. If configure is
run with --enable-bpf-compiler, the script succeeds, but make fails.
This small patch adds a test for the dependency (libpcap) in configure
and fails hard if not found.
---
This small patch addresses your comment when merging the original
nfbpf_compiler commit 1ac30c97c339957b6e3c5cf571de7bc38c827730.
Sorry that it took me so long. Maybe it is not relevant anymore.
---
configure.ac | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/configure.ac b/configure.ac
index d165d52..d443706 100644
--- a/configure.ac
+++ b/configure.ac
@@ -93,6 +93,11 @@ AM_CONDITIONAL([ENABLE_DEVEL], [test "$enable_devel" = "yes"])
AM_CONDITIONAL([ENABLE_LIBIPQ], [test "$enable_libipq" = "yes"])
AM_CONDITIONAL([ENABLE_BPFC], [test "$enable_bpfc" = "yes"])
+if test "x$enable_bpfc" = "xyes"; then
+ AC_CHECK_LIB(pcap, pcap_compile, ,
+ AC_MSG_ERROR(pcap library required by optional component))
+fi
+
PKG_CHECK_MODULES([libnfnetlink], [libnfnetlink >= 1.0],
[nfnetlink=1], [nfnetlink=0])
AM_CONDITIONAL([HAVE_LIBNFNETLINK], [test "$nfnetlink" = 1])
--
1.8.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] build: fail in configure on missing dependency for optional component
2013-07-22 0:02 [PATCH] build: fail in configure on missing dependency for optional component Willem de Bruijn
@ 2013-07-26 14:33 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2013-07-26 14:33 UTC (permalink / raw)
To: Willem de Bruijn; +Cc: netfilter-devel
On Sun, Jul 21, 2013 at 08:02:38PM -0400, Willem de Bruijn wrote:
> The build of utils/nfbpf_compile depends on libpcap. If configure is
> run with --enable-bpf-compiler, the script succeeds, but make fails.
>
> This small patch adds a test for the dependency (libpcap) in configure
> and fails hard if not found.
>
> ---
>
> This small patch addresses your comment when merging the original
> nfbpf_compiler commit 1ac30c97c339957b6e3c5cf571de7bc38c827730.
> Sorry that it took me so long. Maybe it is not relevant anymore.
Yes, I still want this in the tree. Applied, thanks Willem.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-26 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-22 0:02 [PATCH] build: fail in configure on missing dependency for optional component Willem de Bruijn
2013-07-26 14:33 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).