[PATCH] netfilter: ipset: Fix configure failure when --with-kmod=no

[PATCH] netfilter: ipset: Fix configure failure when --with-kmod=no

[Oliver]

From: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>

The following patch fixes a build failure when configuring the sources to build
without kernel modules enabled.

I ran into this issue while writing a Gentoo ebuild to compile ipset 6.20 - it
would be appreciated if there could perhaps be a minor release made to address
this issue.

Signed-off-by: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>

Oliver Smith (1):
  netfilter: ipset: Fix configure failure when --with-kmod=no

 configure.ac | 3 +++
 1 file changed, 3 insertions(+)

-- 
1.8.3.2

[PATCH] netfilter: ipset: Fix configure failure when --with-kmod=no

[Oliver]

From: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>

When configuring the sources to build without kernel modules, the path
to the kernel sources was not set and the kernel header files were still
checked.

Now, we do not check the kernel sources for compatibility if we're not
going to build any kernel modules.

Signed-off-by: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>
---
 configure.ac | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure.ac b/configure.ac
index 0eb1022..d56328c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -167,6 +167,8 @@ AC_CHECK_TYPES([union nf_inet_addr],,,[#include <linux/types.h>
 dnl Checks for functions
 AC_CHECK_FUNCS(gethostbyname2)
 
+if test "$BUILDKMOD" == "yes"
+then
 dnl Check kernel incompatibilities... Ugly like hell
 AC_MSG_CHECKING([kernel source for struct xt_action_param])
 if test -f $ksourcedir/include/linux/netfilter/x_tables.h && \
@@ -309,6 +311,7 @@ else
 	AC_MSG_RESULT(no)
 	AC_MSG_ERROR([Netns support is required in the Linux kernel tree])
 fi
+fi
 
 dnl Checks for compiler characteristics.
 dnl Check extra warning flags except
-- 
1.8.3.2

Re: [PATCH] netfilter: ipset: Fix configure failure when --with-kmod=no

[Jozsef Kadlecsik]

On Fri, 11 Oct 2013, Oliver wrote:

> From: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>
> 
> When configuring the sources to build without kernel modules, the path
> to the kernel sources was not set and the kernel header files were still
> checked.
> 
> Now, we do not check the kernel sources for compatibility if we're not
> going to build any kernel modules.
> 
> Signed-off-by: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>

Patch applied, thanks.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary