From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH libnftables] set_elem: fix access after free in case of parsing errors
Date: Mon, 21 Oct 2013 14:52:48 +0200 [thread overview]
Message-ID: <1382359968-5345-1-git-send-email-pablo@netfilter.org> (raw)
If this fails to parse a set element, stop the processing.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/set_elem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/set_elem.c b/src/set_elem.c
index 5bb82f6..5ef46f2 100644
--- a/src/set_elem.c
+++ b/src/set_elem.c
@@ -298,8 +298,10 @@ static int nft_set_elems_parse2(struct nft_set *s, const struct nlattr *nest)
break;
}
}
- if (ret < 0)
+ if (ret < 0) {
xfree(e);
+ return -1;
+ }
/* Add this new element to this set */
list_add_tail(&e->head, &s->element_list);
--
1.7.10.4
reply other threads:[~2013-10-21 12:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382359968-5345-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).