* [PATCH libnftables] set_elem: fix access after free in case of parsing errors
@ 2013-10-21 12:52 Pablo Neira Ayuso
0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2013-10-21 12:52 UTC (permalink / raw)
To: netfilter-devel
If this fails to parse a set element, stop the processing.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/set_elem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/set_elem.c b/src/set_elem.c
index 5bb82f6..5ef46f2 100644
--- a/src/set_elem.c
+++ b/src/set_elem.c
@@ -298,8 +298,10 @@ static int nft_set_elems_parse2(struct nft_set *s, const struct nlattr *nest)
break;
}
}
- if (ret < 0)
+ if (ret < 0) {
xfree(e);
+ return -1;
+ }
/* Add this new element to this set */
list_add_tail(&e->head, &s->element_list);
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-10-21 12:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 12:52 [PATCH libnftables] set_elem: fix access after free in case of parsing errors Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).