From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Leblond Subject: Re: [PATCH] ulogd: ulogd_inppkt_NFLOG: close nflog handle after unbinding Date: Mon, 18 Nov 2013 23:32:12 +0100 Message-ID: <1384813932.7983.7.camel@tiger2> References: <1384772954-20144-1-git-send-email-bootc@bootc.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Chris Boot Return-path: Received: from ks28632.kimsufi.com ([91.121.96.152]:51769 "EHLO ks28632.kimsufi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374Ab3KRWcW (ORCPT ); Mon, 18 Nov 2013 17:32:22 -0500 In-Reply-To: <1384772954-20144-1-git-send-email-bootc@bootc.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Hello, On Mon, 2013-11-18 at 11:09 +0000, Chris Boot wrote: > The nflog handle is closed, and then nflog_unbind_pf() is called on it, which > triggers an assertion failure within libnfnetlink. This patch simply moves > the nflog_close() just after the nflog_unbind_pf() calls. > > Signed-off-by: Chris Boot Thanks a lot applied. BR, > --- > > The below information is included in the Debian patch file (Debian's DEP-3 > patch tagging guidelines): > > Author: Chris Boot > Bug: https://bugzilla.netfilter.org/show_bug.cgi?id=871 > Bug-Debian: http://bugs.debian.org/729055 > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1250520 > Forwarded: https://bugzilla.netfilter.org/attachment.cgi?id=425 > Last-Update: 2013-11-15 > > Regards, > Chris > > --- ulogd2-2.0.2.orig/input/packet/ulogd_inppkt_NFLOG.c > +++ ulogd2-2.0.2/input/packet/ulogd_inppkt_NFLOG.c > @@ -618,12 +618,12 @@ static int start(struct ulogd_pluginstan > return 0; > > out_bind: > - nflog_close(ui->nful_h); > if (group_ce(upi->config_kset).u.value == 0) { > nflog_unbind_pf(ui->nful_h, AF_INET); > nflog_unbind_pf(ui->nful_h, AF_INET6); > nflog_unbind_pf(ui->nful_h, AF_BRIDGE); > } > + nflog_close(ui->nful_h); > out_handle: > free(ui->nfulog_buf); > out_buf: > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Eric Leblond Blog: https://home.regit.org/