* [PATCH] expr: log: fixed error in nft_rule_expr_parse
@ 2013-11-19 12:01 Ana Rey
2013-11-19 19:09 ` Eric Leblond
2013-11-19 20:11 ` Pablo Neira Ayuso
0 siblings, 2 replies; 3+ messages in thread
From: Ana Rey @ 2013-11-19 12:01 UTC (permalink / raw)
To: netfilter-devel
I fix it by allocating the correct value.
---
src/expr/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/expr/log.c b/src/expr/log.c
index 2d3e0cf..495c1bd 100644
--- a/src/expr/log.c
+++ b/src/expr/log.c
@@ -142,7 +142,7 @@ nft_rule_expr_log_parse(struct nft_rule_expr *e, struct nlattr *attr)
xfree(log->prefix);
log->prefix = strdup(mnl_attr_get_str(tb[NFTA_LOG_PREFIX]));
- e->flags |= (1 << NFT_EXPR_LOG_GROUP);
+ e->flags |= (1 << NFT_EXPR_LOG_PREFIX);
}
if (tb[NFTA_LOG_GROUP]) {
log->group = ntohs(mnl_attr_get_u16(tb[NFTA_LOG_GROUP]));
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] expr: log: fixed error in nft_rule_expr_parse
2013-11-19 12:01 [PATCH] expr: log: fixed error in nft_rule_expr_parse Ana Rey
@ 2013-11-19 19:09 ` Eric Leblond
2013-11-19 20:11 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Eric Leblond @ 2013-11-19 19:09 UTC (permalink / raw)
To: Ana Rey; +Cc: netfilter-devel
Hi,
Good catch. ACK.
Small thing, please modify the subject prefix so we know what is the
target of this patch. For example, use [libnftables PATCH] instead of
[PATCH]. You can use --subject-prefix of git to do so.
On Tue, 2013-11-19 at 13:01 +0100, Ana Rey wrote:
> I fix it by allocating the correct value.
> ---
> src/expr/log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/expr/log.c b/src/expr/log.c
> index 2d3e0cf..495c1bd 100644
> --- a/src/expr/log.c
> +++ b/src/expr/log.c
> @@ -142,7 +142,7 @@ nft_rule_expr_log_parse(struct nft_rule_expr *e, struct nlattr *attr)
> xfree(log->prefix);
>
> log->prefix = strdup(mnl_attr_get_str(tb[NFTA_LOG_PREFIX]));
> - e->flags |= (1 << NFT_EXPR_LOG_GROUP);
> + e->flags |= (1 << NFT_EXPR_LOG_PREFIX);
> }
> if (tb[NFTA_LOG_GROUP]) {
> log->group = ntohs(mnl_attr_get_u16(tb[NFTA_LOG_GROUP]));
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] expr: log: fixed error in nft_rule_expr_parse
2013-11-19 12:01 [PATCH] expr: log: fixed error in nft_rule_expr_parse Ana Rey
2013-11-19 19:09 ` Eric Leblond
@ 2013-11-19 20:11 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2013-11-19 20:11 UTC (permalink / raw)
To: Ana Rey; +Cc: netfilter-devel
On Tue, Nov 19, 2013 at 01:01:16PM +0100, Ana Rey wrote:
> I fix it by allocating the correct value.
Applied, thanks Ana.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-19 20:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19 12:01 [PATCH] expr: log: fixed error in nft_rule_expr_parse Ana Rey
2013-11-19 19:09 ` Eric Leblond
2013-11-19 20:11 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).