From: Eric Leblond <eric@regit.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] expr: log: fixed error in nft_rule_expr_parse
Date: Tue, 19 Nov 2013 20:09:57 +0100 [thread overview]
Message-ID: <1384888197.25788.5.camel@tiger2> (raw)
In-Reply-To: <1384862476-3413-1-git-send-email-anarey@gmail.com>
Hi,
Good catch. ACK.
Small thing, please modify the subject prefix so we know what is the
target of this patch. For example, use [libnftables PATCH] instead of
[PATCH]. You can use --subject-prefix of git to do so.
On Tue, 2013-11-19 at 13:01 +0100, Ana Rey wrote:
> I fix it by allocating the correct value.
> ---
> src/expr/log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/expr/log.c b/src/expr/log.c
> index 2d3e0cf..495c1bd 100644
> --- a/src/expr/log.c
> +++ b/src/expr/log.c
> @@ -142,7 +142,7 @@ nft_rule_expr_log_parse(struct nft_rule_expr *e, struct nlattr *attr)
> xfree(log->prefix);
>
> log->prefix = strdup(mnl_attr_get_str(tb[NFTA_LOG_PREFIX]));
> - e->flags |= (1 << NFT_EXPR_LOG_GROUP);
> + e->flags |= (1 << NFT_EXPR_LOG_PREFIX);
> }
> if (tb[NFTA_LOG_GROUP]) {
> log->group = ntohs(mnl_attr_get_u16(tb[NFTA_LOG_GROUP]));
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
next prev parent reply other threads:[~2013-11-19 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 12:01 [PATCH] expr: log: fixed error in nft_rule_expr_parse Ana Rey
2013-11-19 19:09 ` Eric Leblond [this message]
2013-11-19 20:11 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384888197.25788.5.camel@tiger2 \
--to=eric@regit.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).