* [PATCH net-next] netfilter: add IPComp extension match support
@ 2013-11-28 2:53 Fan Du
2013-12-05 18:34 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Fan Du @ 2013-11-28 2:53 UTC (permalink / raw)
To: steffen.klassert, pablo; +Cc: kaber, netdev, netfilter-devel
With this plugin, user could specify IPComp tagged with certain
CPI that host not interested will be DROPped or any other action.
For example:
iptables -A INPUT -p 108 -m ipcomp --ipcompspi 0x87 -j DROP
Then input IPComp packet with CPI equates 0x87 will not reach
upper layer anymore.
Signed-off-by: Fan Du <fan.du@windriver.com>
---
include/uapi/linux/netfilter_ipv4/ipt_comp.h | 17 +++++
net/ipv4/netfilter/Kconfig | 9 +++
net/ipv4/netfilter/Makefile | 1 +
net/ipv4/netfilter/ipt_comp.c | 101 ++++++++++++++++++++++++++
4 files changed, 128 insertions(+)
create mode 100644 include/uapi/linux/netfilter_ipv4/ipt_comp.h
create mode 100644 net/ipv4/netfilter/ipt_comp.c
diff --git a/include/uapi/linux/netfilter_ipv4/ipt_comp.h b/include/uapi/linux/netfilter_ipv4/ipt_comp.h
new file mode 100644
index 0000000..d072202
--- /dev/null
+++ b/include/uapi/linux/netfilter_ipv4/ipt_comp.h
@@ -0,0 +1,17 @@
+#ifndef _IPT_COMP_H
+#define _IPT_COMP_H
+
+#include <linux/types.h>
+
+struct ipt_comp {
+ __u32 spis[2]; /* Security Parameter Index */
+ __u8 invflags; /* Inverse flags */
+};
+
+
+
+/* Values for "invflags" field in struct ipt_comp. */
+#define IPT_IPCOMP_INV_SPI 0x01 /* Invert the sense of spi. */
+#define IPT_IPCOMP_INV_MASK 0x01 /* All possible flags. */
+
+#endif /*_IPT_COMP_H*/
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index 40d5607..f71cf7b 100644
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -81,6 +81,15 @@ config IP_NF_MATCH_AH
To compile it as a module, choose M here. If unsure, say N.
+config IP_NF_MATCH_IPCOMP
+ tristate '"ipcomp" match support'
+ depends on NETFILTER_ADVANCED
+ help
+ This match extension allows you to match a range of SPIs (Actually it's
+ Compression Parameter Index(CPI) inside IPComp header of IPSec packets.
+
+ To compile it as a module, choose M here. If unsure, say N.
+
config IP_NF_MATCH_ECN
tristate '"ecn" match support'
depends on NETFILTER_ADVANCED
diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 19df72b..b67ecb8 100644
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -45,6 +45,7 @@ obj-$(CONFIG_IP_NF_SECURITY) += iptable_security.o
# matches
obj-$(CONFIG_IP_NF_MATCH_AH) += ipt_ah.o
+obj-$(CONFIG_IP_NF_MATCH_IPCOMP) += ipt_comp.o
obj-$(CONFIG_IP_NF_MATCH_RPFILTER) += ipt_rpfilter.o
# targets
diff --git a/net/ipv4/netfilter/ipt_comp.c b/net/ipv4/netfilter/ipt_comp.c
new file mode 100644
index 0000000..7796e6e
--- /dev/null
+++ b/net/ipv4/netfilter/ipt_comp.c
@@ -0,0 +1,101 @@
+/* Kernel module to match IPComp parameters
+ *
+ * Copyright (C) 2013 WindRiver
+ *
+ * Author:
+ * Fan Du <fan.du@windriver.com>
+ *
+ * Based on:
+ * net/ipv4/netfilter/ipt_ah.c
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <linux/in.h>
+#include <linux/module.h>
+#include <linux/skbuff.h>
+#include <linux/ip.h>
+
+#include <linux/netfilter_ipv4/ipt_comp.h>
+#include <linux/netfilter/x_tables.h>
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Fan Du <fan.du@windriver.com>");
+MODULE_DESCRIPTION("Xtables: IPv4 IPsec-IPComp SPI match");
+
+/* Returns 1 if the spi is matched by the range, 0 otherwise */
+static inline bool
+spi_match(u_int32_t min, u_int32_t max, u_int32_t spi, bool invert)
+{
+ bool r;
+ pr_debug("spi_match:%c 0x%x <= 0x%x <= 0x%x\n",
+ invert ? '!' : ' ', min, spi, max);
+ r = (spi >= min && spi <= max) ^ invert;
+ pr_debug(" result %s\n", r ? "PASS" : "FAILED");
+ return r;
+}
+
+static bool comp_mt(const struct sk_buff *skb, struct xt_action_param *par)
+{
+ struct ip_comp_hdr _comphdr;
+ const struct ip_comp_hdr *chdr;
+ const struct ipt_comp *compinfo = par->matchinfo;
+
+ /* Must not be a fragment. */
+ if (par->fragoff != 0)
+ return false;
+
+ chdr = skb_header_pointer(skb, par->thoff, sizeof(_comphdr), &_comphdr);
+ if (chdr == NULL) {
+ /* We've been asked to examine this packet, and we
+ * can't. Hence, no choice but to drop.
+ */
+ pr_debug("Dropping evil IPComp tinygram.\n");
+ par->hotdrop = true;
+ return 0;
+ }
+
+ return spi_match(compinfo->spis[0], compinfo->spis[1],
+ ntohl(chdr->cpi << 16),
+ !!(compinfo->invflags & IPT_IPCOMP_INV_SPI));
+}
+
+static int comp_mt_check(const struct xt_mtchk_param *par)
+{
+ const struct ipt_comp *compinfo = par->matchinfo;
+
+ /* Must specify no unknown invflags */
+ if (compinfo->invflags & ~IPT_IPCOMP_INV_MASK) {
+ pr_debug("unknown flags %X\n", compinfo->invflags);
+ return -EINVAL;
+ }
+ return 0;
+}
+
+static struct xt_match comp_mt_reg __read_mostly = {
+ .name = "ipcomp",
+ .family = NFPROTO_IPV4,
+ .match = comp_mt,
+ .matchsize = sizeof(struct ipt_comp),
+ .proto = IPPROTO_COMP,
+ .checkentry = comp_mt_check,
+ .me = THIS_MODULE,
+};
+
+static int __init comp_mt_init(void)
+{
+ return xt_register_match(&comp_mt_reg);
+}
+
+static void __exit comp_mt_exit(void)
+{
+ xt_unregister_match(&comp_mt_reg);
+}
+
+module_init(comp_mt_init);
+module_exit(comp_mt_exit);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] netfilter: add IPComp extension match support
2013-11-28 2:53 [PATCH net-next] netfilter: add IPComp extension match support Fan Du
@ 2013-12-05 18:34 ` Pablo Neira Ayuso
2013-12-06 9:56 ` Fan Du
0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2013-12-05 18:34 UTC (permalink / raw)
To: Fan Du; +Cc: steffen.klassert, kaber, netdev, netfilter-devel
Hi,
On Thu, Nov 28, 2013 at 10:53:24AM +0800, Fan Du wrote:
> With this plugin, user could specify IPComp tagged with certain
> CPI that host not interested will be DROPped or any other action.
>
> For example:
> iptables -A INPUT -p 108 -m ipcomp --ipcompspi 0x87 -j DROP
>
> Then input IPComp packet with CPI equates 0x87 will not reach
> upper layer anymore.
I think that, with a little bit more work, you can add support for
IPv6 as well. From RFC 3173:
"In the IPv6 context, IPComp is viewed as an end-to-end payload, and
MUST NOT apply to hop-by-hop, routing, and fragmentation extension
headers.
You can perform that IPv6-specific handling to skip these extension
headers and reach the IPComp header by means of the ipv6_find_hdr()
helper function.
BTW, please post the iptables userspace part as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] netfilter: add IPComp extension match support
2013-12-05 18:34 ` Pablo Neira Ayuso
@ 2013-12-06 9:56 ` Fan Du
2013-12-07 23:55 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Fan Du @ 2013-12-06 9:56 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: steffen.klassert, kaber, netdev, netfilter-devel
On 2013年12月06日 02:34, Pablo Neira Ayuso wrote:
> Hi,
>
> On Thu, Nov 28, 2013 at 10:53:24AM +0800, Fan Du wrote:
>> With this plugin, user could specify IPComp tagged with certain
>> CPI that host not interested will be DROPped or any other action.
>>
>> For example:
>> iptables -A INPUT -p 108 -m ipcomp --ipcompspi 0x87 -j DROP
>>
>> Then input IPComp packet with CPI equates 0x87 will not reach
>> upper layer anymore.
>
> I think that, with a little bit more work, you can add support for
> IPv6 as well. From RFC 3173:
>
> "In the IPv6 context, IPComp is viewed as an end-to-end payload, and
> MUST NOT apply to hop-by-hop, routing, and fragmentation extension
> headers.
>
> You can perform that IPv6-specific handling to skip these extension
> headers and reach the IPComp header by means of the ipv6_find_hdr()
> helper function.
>
> BTW, please post the iptables userspace part as well.
Thanks for your attention, Pablo.
I will try to finish your request this weekend, hopefully post the whole
patch set in early next week.
--
浮沉随浪只记今朝笑
--fan fan
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] netfilter: add IPComp extension match support
2013-12-06 9:56 ` Fan Du
@ 2013-12-07 23:55 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2013-12-07 23:55 UTC (permalink / raw)
To: Fan Du; +Cc: steffen.klassert, kaber, netdev, netfilter-devel
On Fri, Dec 06, 2013 at 05:56:09PM +0800, Fan Du wrote:
>
>
> On 2013年12月06日 02:34, Pablo Neira Ayuso wrote:
> >Hi,
> >
> >On Thu, Nov 28, 2013 at 10:53:24AM +0800, Fan Du wrote:
> >>With this plugin, user could specify IPComp tagged with certain
> >>CPI that host not interested will be DROPped or any other action.
> >>
> >>For example:
> >>iptables -A INPUT -p 108 -m ipcomp --ipcompspi 0x87 -j DROP
> >>
> >>Then input IPComp packet with CPI equates 0x87 will not reach
> >>upper layer anymore.
> >
> >I think that, with a little bit more work, you can add support for
> >IPv6 as well. From RFC 3173:
> >
> >"In the IPv6 context, IPComp is viewed as an end-to-end payload, and
> >MUST NOT apply to hop-by-hop, routing, and fragmentation extension
> >headers.
> >
> >You can perform that IPv6-specific handling to skip these extension
> >headers and reach the IPComp header by means of the ipv6_find_hdr()
> >helper function.
I just noted that you always have to use -p 108 to get this match
working, in that case the ip6_tables already sets par->thoff that you
can use to reach the transport header, so you can skip calling
ipv6_find_hdr(). So adding IPv6 support is even easier to make.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-07 23:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 2:53 [PATCH net-next] netfilter: add IPComp extension match support Fan Du
2013-12-05 18:34 ` Pablo Neira Ayuso
2013-12-06 9:56 ` Fan Du
2013-12-07 23:55 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).