[PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread

[PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread

[Gustavo Zacarias]

Some uClibc-based toolchains lack threading support, so use
AC_SEARCH_LIB instead of AC_CHECK_LIB to check for libpthread
availability and link conditionally if found since it's only used for
the database backends.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 configure.ac    | 3 ++-
 src/Makefile.am | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 7f5ffa9..5e45aaa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,7 +39,8 @@ AC_CHECK_FUNCS(socket strerror)
 regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
 AC_SUBST([regular_CFLAGS])
 
-AC_CHECK_LIB(pthread, pthread_create)
+AC_SEARCH_LIBS([pthread_create], [pthread], [libpthread_LIBS="$LIBS"; LIBS=""])
+AC_SUBST([libpthread_LIBS])
 
 dnl Check for the right nfnetlink version
 PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
diff --git a/src/Makefile.am b/src/Makefile.am
index 1097468..998e776 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -7,5 +7,5 @@ AM_CFLAGS = ${regular_CFLAGS}
 sbin_PROGRAMS = ulogd
 
 ulogd_SOURCES = ulogd.c select.c timer.c rbtree.c conffile.c hash.c addr.c
-ulogd_LDADD   = ${libdl_LIBS}
-ulogd_LDFLAGS = -export-dynamic -lpthread
+ulogd_LDADD   = ${libdl_LIBS} ${libpthread_LIBS}
+ulogd_LDFLAGS = -export-dynamic
-- 
1.8.3.2

Re: [PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread

[Eric Leblond]

Hello,
On Tue, 2013-12-10 at 09:24 -0300, Gustavo Zacarias wrote:
> Some uClibc-based toolchains lack threading support, so use
> AC_SEARCH_LIB instead of AC_CHECK_LIB to check for libpthread
> availability and link conditionally if found since it's only used for
> the database backends.

Is there some need for this type of systems to have access to the
database backends ? In this case, it will be interesting to make
conditional the build of the new thread running mode.

BR,

> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  configure.ac    | 3 ++-
>  src/Makefile.am | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7f5ffa9..5e45aaa 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -39,7 +39,8 @@ AC_CHECK_FUNCS(socket strerror)
>  regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
>  AC_SUBST([regular_CFLAGS])
>  
> -AC_CHECK_LIB(pthread, pthread_create)
> +AC_SEARCH_LIBS([pthread_create], [pthread], [libpthread_LIBS="$LIBS"; LIBS=""])
> +AC_SUBST([libpthread_LIBS])
>  
>  dnl Check for the right nfnetlink version
>  PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 1097468..998e776 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -7,5 +7,5 @@ AM_CFLAGS = ${regular_CFLAGS}
>  sbin_PROGRAMS = ulogd
>  
>  ulogd_SOURCES = ulogd.c select.c timer.c rbtree.c conffile.c hash.c addr.c
> -ulogd_LDADD   = ${libdl_LIBS}
> -ulogd_LDFLAGS = -export-dynamic -lpthread
> +ulogd_LDADD   = ${libdl_LIBS} ${libpthread_LIBS}
> +ulogd_LDFLAGS = -export-dynamic

-- 
Eric Leblond <eric@regit.org>

Re: [PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread

[Gustavo Zacarias]

On 12/10/2013 09:46 PM, Eric Leblond wrote:

> Is there some need for this type of systems to have access to the
> database backends ? In this case, it will be interesting to make
> conditional the build of the new thread running mode.

My $.02 say no, it's probably not worth the effort, such a system would
probably be resourceful (not memory/storage constrained) and just be
able to use a threaded libc (an ARM uClibc libpthread is ~68 KiB stripped).
Regards.

Re: [PATCH ulogd] ulogd: use AC_SEARCH_LIBS for libpthread

[Eric Leblond]

Hello,

On Tue, 2013-12-10 at 09:24 -0300, Gustavo Zacarias wrote:
> Some uClibc-based toolchains lack threading support, so use
> AC_SEARCH_LIB instead of AC_CHECK_LIB to check for libpthread
> availability and link conditionally if found since it's only used for
> the database backends.

Thanks a lot. Patch pushed to git.

BR,

> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  configure.ac    | 3 ++-
>  src/Makefile.am | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7f5ffa9..5e45aaa 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -39,7 +39,8 @@ AC_CHECK_FUNCS(socket strerror)
>  regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
>  AC_SUBST([regular_CFLAGS])
>  
> -AC_CHECK_LIB(pthread, pthread_create)
> +AC_SEARCH_LIBS([pthread_create], [pthread], [libpthread_LIBS="$LIBS"; LIBS=""])
> +AC_SUBST([libpthread_LIBS])
>  
>  dnl Check for the right nfnetlink version
>  PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 1097468..998e776 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -7,5 +7,5 @@ AM_CFLAGS = ${regular_CFLAGS}
>  sbin_PROGRAMS = ulogd
>  
>  ulogd_SOURCES = ulogd.c select.c timer.c rbtree.c conffile.c hash.c addr.c
> -ulogd_LDADD   = ${libdl_LIBS}
> -ulogd_LDFLAGS = -export-dynamic -lpthread
> +ulogd_LDADD   = ${libdl_LIBS} ${libpthread_LIBS}
> +ulogd_LDFLAGS = -export-dynamic

-- 
Eric Leblond <eric@regit.org>