netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Leblond <eric@regit.org>
To: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Cc: Eric Leblond <eric@regit.org>
Subject: [PATCH 1/2] netfilter: nft: select NFNETLINK
Date: Sun, 29 Dec 2013 11:01:29 +0100	[thread overview]
Message-ID: <1388311290-18366-2-git-send-email-eric@regit.org> (raw)
In-Reply-To: <1388311290-18366-1-git-send-email-eric@regit.org>

In Kconfig, nft is set as depending on NFNETLINK so building nft as a
module or inside kernel is depending of the state of NFNETLINK inside
the kernel config. If someone wants to build nftables inside the
kernel, it is necessary to also build NFNETLINK inside the kernel.
But NFNETLINK can not be set in the menu so it is necessary to toggle
an external value such as logging or nfacct to have a switch of
NFNETLINK to kernel build.
This patch change the dependency to a select inside Kconfig to be able
to set the build of nftables as modules or inside kernel independently.

Signed-off-by: Eric Leblond <eric@regit.org>
---
 net/netfilter/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 4371c98..01f9f64 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -414,7 +414,7 @@ config NETFILTER_SYNPROXY
 endif # NF_CONNTRACK
 
 config NF_TABLES
-	depends on NETFILTER_NETLINK
+	select NETFILTER_NETLINK
 	tristate "Netfilter nf_tables support"
 
 config NFT_EXTHDR
-- 
1.8.5.2


  reply	other threads:[~2013-12-29 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-29 10:01 [PATCH 0/2] nftables: minor Kconfig fixes Eric Leblond
2013-12-29 10:01 ` Eric Leblond [this message]
2013-12-30 17:18   ` [PATCH 1/2] netfilter: nft: select NFNETLINK Pablo Neira Ayuso
2013-12-29 10:01 ` [PATCH 2/2] netfilter: nft: explicit dependency to IPv6 Eric Leblond
2013-12-29 11:00   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388311290-18366-2-git-send-email-eric@regit.org \
    --to=eric@regit.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).