[PATCH] netfilter: nftables: fix warning in nft_reject

[PATCH] netfilter: nftables: fix warning in nft_reject

[Eric Leblond]

The 0-day testing from Fenguang Wu issued the following warning:
 net/netfilter/nft_reject.c: In function 'nft_reject_eval':
 >> net/netfilter/nft_reject.c:37:14: warning: unused variable 'net' [-Wunused-variable]
      struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out);

This is due to the fact that if IPv6 is not build the variable is
indeed unused.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Eric Leblond <eric@regit.org>
---
 net/netfilter/nft_reject.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/netfilter/nft_reject.c b/net/netfilter/nft_reject.c
index 0d690d4..c65fbd8 100644
--- a/net/netfilter/nft_reject.c
+++ b/net/netfilter/nft_reject.c
@@ -34,7 +34,9 @@ static void nft_reject_eval(const struct nft_expr *expr,
 			      const struct nft_pktinfo *pkt)
 {
 	struct nft_reject *priv = nft_expr_priv(expr);
+#if IS_ENABLED(CONFIG_NF_TABLES_IPV6)
 	struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out);
+#endif
 
 	switch (priv->type) {
 	case NFT_REJECT_ICMP_UNREACH:
-- 
1.8.5.2

Re: [PATCH] netfilter: nftables: fix warning in nft_reject

[Pablo Neira Ayuso]

On Mon, Jan 06, 2014 at 10:19:14PM +0100, Eric Leblond wrote:
> The 0-day testing from Fenguang Wu issued the following warning:
>  net/netfilter/nft_reject.c: In function 'nft_reject_eval':
>  >> net/netfilter/nft_reject.c:37:14: warning: unused variable 'net' [-Wunused-variable]
>       struct net *net = dev_net((pkt->in != NULL) ? pkt->in : pkt->out);
> 
> This is due to the fact that if IPv6 is not build the variable is
> indeed unused.

Thanks Eric.

I sent this patch a bit earlier to address this:

http://patchwork.ozlabs.org/patch/307435/