From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 4/4] meta: fix crash when parsing unresolvable mark values
Date: Fri, 10 Jan 2014 09:31:34 +0000 [thread overview]
Message-ID: <1389346294-7242-5-git-send-email-kaber@trash.net> (raw)
In-Reply-To: <1389346294-7242-1-git-send-email-kaber@trash.net>
*res has undefined contents, set to NULL before invoking the parse function
to make sure the test for != NULL doesn't falsely return true.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
src/datatype.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/datatype.c b/src/datatype.c
index 9910a1b..86ea80e 100644
--- a/src/datatype.c
+++ b/src/datatype.c
@@ -643,6 +643,7 @@ static struct error_record *mark_type_parse(const struct expr *sym,
}
}
+ *res = NULL;
erec = sym->dtype->basetype->parse(sym, res);
if (erec != NULL)
return erec;
--
1.8.4.2
prev parent reply other threads:[~2014-01-10 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 9:31 [PATCH 0/4] nftables: bug fixes and minor cleanups Patrick McHardy
2014-01-10 9:31 ` [PATCH 1/4] nftables: shorten "could not process rule in batch" message Patrick McHardy
2014-01-10 9:31 ` [PATCH 2/4] erec: fix error markup for errors starting at column 0 Patrick McHardy
2014-01-10 9:31 ` [PATCH 3/4] datatype: revert "fix crash if wrong integer type is passed" Patrick McHardy
2014-01-10 9:31 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389346294-7242-5-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).