From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH 3/3] scanner: rename address selector from 'eth' to 'ether'
Date: Tue, 14 Jan 2014 12:30:30 +0100 [thread overview]
Message-ID: <1389699030-6301-4-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1389699030-6301-1-git-send-email-pablo@netfilter.org>
eth is may easily ocur when using ifname mask. This could be also
fixed by interpreting 'eth' as a simple string in the parser but
I think this selector also looks more similar to what we use in
tcpdump.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/parser.y | 4 ++--
src/scanner.l | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/parser.y b/src/parser.y
index 26e71e3..461eb3f 100644
--- a/src/parser.y
+++ b/src/parser.y
@@ -193,7 +193,7 @@ static void location_update(struct location *loc, struct location *rhs, int n)
%token BRIDGE "bridge"
-%token ETH "eth"
+%token ETHER "ether"
%token SADDR "saddr"
%token DADDR "daddr"
%token TYPE "type"
@@ -1392,7 +1392,7 @@ payload_base_spec : LL_HDR { $$ = PAYLOAD_BASE_LL_HDR; }
| TRANSPORT_HDR { $$ = PAYLOAD_BASE_TRANSPORT_HDR; }
;
-eth_hdr_expr : ETH eth_hdr_field
+eth_hdr_expr : ETHER eth_hdr_field
{
$$ = payload_expr_alloc(&@$, &payload_eth, $2);
}
diff --git a/src/scanner.l b/src/scanner.l
index 2d7ac88..a4db017 100644
--- a/src/scanner.l
+++ b/src/scanner.l
@@ -278,7 +278,7 @@ addrstring ({macaddr}|{ip4addr}|{ip6addr})
"bridge" { return BRIDGE; }
-"eth" { return ETH; }
+"ether" { return ETHER; }
"saddr" { return SADDR; }
"daddr" { return DADDR; }
"type" { return TYPE; }
--
1.7.10.4
next prev parent reply other threads:[~2014-01-14 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 11:30 [PATCH 0/3 nft] [RFC] more syntax changes Pablo Neira Ayuso
2014-01-14 11:30 ` [PATCH 1/3] scanner: replace binary characters '&' '|' and '!' by their names Pablo Neira Ayuso
2014-01-14 12:00 ` Pablo Neira Ayuso
2014-01-14 12:24 ` Patrick McHardy
2014-01-14 12:21 ` Patrick McHardy
2014-01-14 11:30 ` [PATCH 2/3] evaluate: allow to use string with binary operations Pablo Neira Ayuso
2014-01-14 12:22 ` Patrick McHardy
2014-01-14 15:25 ` Pablo Neira Ayuso
2014-01-14 15:49 ` Patrick McHardy
2014-01-15 9:29 ` Pablo Neira Ayuso
2014-01-15 15:58 ` Pablo Neira Ayuso
2014-01-15 16:05 ` Patrick McHardy
2014-01-14 11:30 ` Pablo Neira Ayuso [this message]
2014-01-14 12:23 ` [PATCH 3/3] scanner: rename address selector from 'eth' to 'ether' Patrick McHardy
2014-01-14 11:47 ` [PATCH 0/3 nft] [RFC] more syntax changes Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389699030-6301-4-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).