From: mathieu.poirier@linaro.org
To: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu
Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
mathieu.poirier@linaro.org
Subject: [PATCH RESEND v2 0/1] Add quota capabilities to nfacct
Date: Sun, 26 Jan 2014 13:04:32 -0700 [thread overview]
Message-ID: <1390766673-21444-1-git-send-email-mathieu.poirier@linaro.org> (raw)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Can I ask one of the maintainers to have a quick look at this please?
The code is simple to understand and the mofications self contained.
We missed the 3.14 merge window, it would be very disappointing to
miss the next one.
This is the second version of the feature rebased on the 3.13 kernel - all
comments from the maintainer have been followed except for the removal of
a spinlock that protects the integrity of an internal accounting structure.
I have sent a scenario for the output path that explains the concequence of
not having the structure guarded by said spinlock but received no answer.
As such I am sending this second version with all comments addressed less
the spinlock removal in the hope of getting more feedback on the matter.
Corresponding iptables modifications can be found here:
https://git.linaro.org/people/mathieu.poirier/iptables.git
Mathieu Poirier (1):
netfilter: xtables: add quota support to nfacct
include/linux/netfilter/nfnetlink_acct.h | 11 ++-
include/uapi/linux/netfilter/nfnetlink.h | 2 +
include/uapi/linux/netfilter/nfnetlink_acct.h | 1 +
include/uapi/linux/netfilter/xt_nfacct.h | 14 ++++
net/netfilter/Kconfig | 3 +-
net/netfilter/nfnetlink_acct.c | 35 ++++++---
net/netfilter/xt_nfacct.c | 107 +++++++++++++++++++++++---
7 files changed, 150 insertions(+), 23 deletions(-)
--
1.8.3.2
next reply other threads:[~2014-01-26 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-26 20:04 mathieu.poirier [this message]
2014-01-26 20:04 ` [PATCH RESEND v2 1/1] netfilter: xtables: add quota support to nfacct mathieu.poirier
2014-01-26 23:02 ` Florian Westphal
2014-01-27 15:35 ` Mathieu Poirier
2014-01-27 16:44 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390766673-21444-1-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).