From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nft] netlink: meta: fix wrong type in attributes
Date: Mon, 17 Feb 2014 16:48:05 +0100 [thread overview]
Message-ID: <1392652085-8225-1-git-send-email-fw@strlen.de> (raw)
We segfault on 'list filter' when meta expr is used as _u8
returns invalid register 0.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/netlink_delinearize.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index 6668308..b976d86 100644
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -346,9 +346,9 @@ static void netlink_parse_meta_sreg(struct netlink_parse_ctx *ctx,
struct expr *expr;
expr = netlink_get_register(ctx, loc,
- nft_rule_expr_get_u8(nle, NFT_EXPR_META_SREG));
+ nft_rule_expr_get_u32(nle, NFT_EXPR_META_SREG));
stmt = meta_stmt_alloc(loc,
- nft_rule_expr_get_u8(nle, NFT_EXPR_META_KEY),
+ nft_rule_expr_get_u32(nle, NFT_EXPR_META_KEY),
expr);
expr_set_type(expr, stmt->meta.tmpl->dtype, stmt->meta.tmpl->byteorder);
--
1.8.1.5
next reply other threads:[~2014-02-17 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:48 Florian Westphal [this message]
2014-02-17 17:25 ` [PATCH nft] netlink: meta: fix wrong type in attributes Patrick McHardy
2014-02-17 19:14 ` Pablo Neira Ayuso
2014-02-17 19:40 ` Patrick McHardy
2014-02-17 21:03 ` Florian Westphal
2014-02-17 22:49 ` Pablo Neira Ayuso
2014-02-18 1:27 ` Patrick McHardy
2014-02-18 10:02 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392652085-8225-1-git-send-email-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).