From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: [PATCH 0/4] nftables: bitmask and prefix fixes
Date: Mon, 17 Feb 2014 17:20:48 +0000 [thread overview]
Message-ID: <1392657652-9815-1-git-send-email-kaber@trash.net> (raw)
These patches fix a problem with bitmask types outside of a flag comparison
noticed by Florian, as well as a couple of bugs in related areas:
- always use FLAGCMP op if RHS of a relational expression has basetype bitmask
- add parens in output of binops when necessary
- fix netlink prefix expression handling
Unless there are objections, I'll push them shortly.
Patrick McHardy (4):
evaluate: use flagcmp for single RHS bitmask expression
binop: take care of operator precedence when printing binop arguments
netlink_delinarize: convert *all* bitmask values into individual bit values
netlink: fix prefix expression handling
include/expression.h | 8 ++++
src/evaluate.c | 6 ++-
src/expression.c | 88 +++++++++++++++++++++++++++++++++++++--
src/netlink.c | 27 ------------
src/netlink_delinearize.c | 104 ++++++++++++++++++++++++++--------------------
src/netlink_linearize.c | 11 ++++-
6 files changed, 165 insertions(+), 79 deletions(-)
next reply other threads:[~2014-02-17 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 17:20 Patrick McHardy [this message]
2014-02-17 17:20 ` [PATCH 1/4] evaluate: use flagcmp for single RHS bitmask expression Patrick McHardy
2014-02-17 17:20 ` [PATCH 2/4] binop: take care of operator precedence when printing binop arguments Patrick McHardy
2014-02-17 17:20 ` [PATCH 3/4] netlink_delinarize: convert *all* bitmask values into individual bit values Patrick McHardy
2014-02-17 17:20 ` [PATCH 4/4] netlink: fix prefix expression handling Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392657652-9815-1-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).