From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: [PATCH -next] netfilter: connlimit: fix UP build Date: Mon, 17 Mar 2014 22:27:50 +0100 Message-ID: <1395091670-28238-1-git-send-email-fw@strlen.de> References: <53275dbf./J0nBeffRcN62Ddt%fengguang.wu@intel.com> Cc: netdev@vger.kernel.org, Florian Westphal To: netfilter-devel@vger.kernel.org Return-path: In-Reply-To: <53275dbf./J0nBeffRcN62Ddt%fengguang.wu@intel.com> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org cannot use ARRAY_SIZE() if spinlock_t is empty struct. Fixes: 1442e7507dd597 ("netfilter: connlimit: use keyed locks") Reported-by: kbuild test robot Signed-off-by: Florian Westphal --- Another one, did UP build with LOCKDEP=y 8-( diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c index 458464e..a6e129e 100644 --- a/net/netfilter/xt_connlimit.c +++ b/net/netfilter/xt_connlimit.c @@ -377,7 +377,7 @@ static int connlimit_mt_check(const struct xt_mtchk_param *par) return -ENOMEM; } - for (i = 0; i < ARRAY_SIZE(info->data->locks); ++i) + for (i = 0; i < CONNLIMIT_LOCK_SLOTS; ++i) spin_lock_init(&info->data->locks[i]); for (i = 0; i < ARRAY_SIZE(info->data->climit_root4); ++i) -- 1.8.1.5