netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netfilter: Add {ipt,ip6t}_osf aliases for xt_osf
@ 2014-03-26 10:37 Kirill Tkhai
  2014-03-30 11:33 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Kirill Tkhai @ 2014-03-26 10:37 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Pablo Neira Ayuso, Patrick McHardy, Jozsef Kadlecsik

There are no these aliases, so kernel can not request appropriate
match table:

$ iptables -I INPUT -p tcp -m osf --genre Windows --ttl 2 -j DROP
iptables: No chain/target/match by that name.

setsockopt() requests ipt_osf module, which is not present. Add
the aliases.

Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
---
 net/netfilter/xt_osf.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c
index 7174611..c529161 100644
--- a/net/netfilter/xt_osf.c
+++ b/net/netfilter/xt_osf.c
@@ -422,4 +422,6 @@ module_exit(xt_osf_fini);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Evgeniy Polyakov <zbr@ioremap.net>");
 MODULE_DESCRIPTION("Passive OS fingerprint matching.");
+MODULE_ALIAS("ipt_osf");
+MODULE_ALIAS("ip6t_osf");
 MODULE_ALIAS_NFNL_SUBSYS(NFNL_SUBSYS_OSF);



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] netfilter: Add {ipt,ip6t}_osf aliases for xt_osf
  2014-03-26 10:37 [PATCH] netfilter: Add {ipt,ip6t}_osf aliases for xt_osf Kirill Tkhai
@ 2014-03-30 11:33 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-03-30 11:33 UTC (permalink / raw)
  To: Kirill Tkhai; +Cc: netfilter-devel, Patrick McHardy, Jozsef Kadlecsik

On Wed, Mar 26, 2014 at 02:37:59PM +0400, Kirill Tkhai wrote:
> There are no these aliases, so kernel can not request appropriate
> match table:
> 
> $ iptables -I INPUT -p tcp -m osf --genre Windows --ttl 2 -j DROP
> iptables: No chain/target/match by that name.
> 
> setsockopt() requests ipt_osf module, which is not present. Add
> the aliases.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-30 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-26 10:37 [PATCH] netfilter: Add {ipt,ip6t}_osf aliases for xt_osf Kirill Tkhai
2014-03-30 11:33 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).