From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: pablo@netfilter.org, kaber@trash.net
Cc: netfilter-devel@vger.kernel.org,
Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Subject: [RFC 0/3] Add support for meta keys, bridge family specific
Date: Thu, 27 Mar 2014 11:19:29 +0200 [thread overview]
Message-ID: <1395911972-17259-1-git-send-email-tomasz.bursztyka@linux.intel.com> (raw)
Hi Patrick and Pablo,
I need your input on that one, thus I am sending it as an RFC.
Patch 1 and 2 are straight forward so I'll skip. (though there might be
improvement to be done. For instance, the init code part is 90% same so
it could be factorized maybe)
Now patch 3: without it, the bridge specific module for meta expression
cannot work: bare meta expression module gets in use since it's generic from
family level.
It's again quite trivial, but I would like your opinion about it.
I was thinking also on different solutions like registering a meta expr type
for every family... but it's not really memory wise.
With patch 3, at worst it loops through the entire expression type list
and this case happens for most of expressions, since they are family agnostic.
So it's not great either...
What do you think?
(Btw, I already made the patches for libnftnl and nftables but I skipped those
for this RFC.)
Tomasz
--
1.8.3.2
next reply other threads:[~2014-03-27 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 9:19 Tomasz Bursztyka [this message]
2014-03-27 9:19 ` [RFC 1/3] netfilter: nf_tables: Make public core function of META expression Tomasz Bursztyka
2014-03-27 9:19 ` [RFC 2/3] netfilter: nf_tables: Add meta expression key for bridge interface name Tomasz Bursztyka
2014-04-08 8:06 ` Pablo Neira Ayuso
2014-04-08 8:20 ` Tomasz Bursztyka
2014-04-08 8:34 ` Pablo Neira Ayuso
2014-04-08 9:04 ` Tomasz Bursztyka
2014-03-27 9:19 ` [RFC 3/3] netfilter: nftables: Return preferably given family expression if any Tomasz Bursztyka
2014-03-27 9:26 ` Patrick McHardy
2014-03-27 11:00 ` Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395911972-17259-1-git-send-email-tomasz.bursztyka@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).