From: Eric Leblond <eric@regit.org>
To: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
Cc: The netfilter developer mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [ulogd RFC PATCH 0/2] introduce new string output plugin
Date: Mon, 31 Mar 2014 22:51:19 +0200 [thread overview]
Message-ID: <1396299079.8629.73.camel@tiger2> (raw)
In-Reply-To: <20140329042336.GA22821@gmail.com>
Hello,
On Sat, 2014-03-29 at 13:23 +0900, Ken-ichirou MATSUZAWA wrote:
> Hello,
>
> I started to add new output plugin which work with graphite or statsd. Would you
> review these patches? I think this SPRINT output plugin has two issues and may
> I ask?
>
> * multiple files for one plugin
> I use flex and bison and need to separate source files. Is it acceptable?
I'm a bit reluctant to use flex and bison for that. How complicated
would it be to use a hand-made parsing here ?
> * use double calc operation
> To tell statsd total amount bytes, I introduce calc operation (but '+' only now)
> not using correct ULOGD_RET_ type but regard all of them as double.
> It seems it is enough as of my purpose.
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
next prev parent reply other threads:[~2014-03-31 20:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 4:23 [ulogd RFC PATCH 0/2] introduce new string output plugin Ken-ichirou MATSUZAWA
2014-03-29 4:27 ` [ulogd RFC PATCH 1/2] sprint: introduce new " Ken-ichirou MATSUZAWA
2014-03-31 21:06 ` Eric Leblond
2014-03-29 4:29 ` [ulogd RFC PATCH 2/2] ip2str: introduce changable address separator Ken-ichirou MATSUZAWA
2014-03-31 20:17 ` Eric Leblond
2014-03-31 20:51 ` Eric Leblond [this message]
2014-04-02 10:14 ` [ulogd RFC PATCH 0/2] introduce new string output plugin Ken-ichirou MATSUZAWA
2014-04-21 9:05 ` Eric Leblond
2014-04-22 11:51 ` [ulogd RFC PATCH 0/2 resend] " Ken-ichirou MATSUZAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396299079.8629.73.camel@tiger2 \
--to=eric@regit.org \
--cc=chamaken@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).