netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: netfilter-devel@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Patrick McHardy <kaber@trash.net>,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
	Michal Kubecek <mkubecek@suse.cz>
Subject: NETFILTER_XT_TARGET_NOTRACK
Date: Thu, 10 Apr 2014 14:05:11 +0200	[thread overview]
Message-ID: <1397131511.25950.97.camel@chaos.site> (raw)

Hi all,

I have a concern / question / suggestion regarding
NETFILTER_XT_TARGET_NOTRACK.

Currently, NETFILTER_XT_TARGET_NOTRACK merely selects
NETFILTER_XT_TARGET_CT, and does nothing else. This means that selecting
or not selecting NETFILTER_XT_TARGET_NOTRACK makes no difference, as
long as NETFILTER_XT_TARGET_CT itself is set.

I seem to understand that NETFILTER_XT_TARGET_NOTRACK was reintroduced
in kernel 3.8 to help migration to NETFILTER_XT_TARGET_CT. I understand
the logic, but this was 7 kernel versions / over 2 years ago. Wouldn't
it be the right time to finally remove NETFILTER_XT_TARGET_NOTRACK?

Alternatively, I find it curious that the compatibility code is
unconditionally built into xt_CT even when NETFILTER_XT_TARGET_NOTRACK
is not selected. Is it an overlook, or is it by design? I think it would
make sense to only build that compatibility code when
NETFILTER_XT_TARGET_NOTRACK is selected. In that case it would make
sense to keep NETFILTER_XT_TARGET_NOTRACK.

Thanks,
-- 
Jean Delvare
SUSE L3 Support


             reply	other threads:[~2014-04-10 12:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 12:05 Jean Delvare [this message]
2014-04-10 13:01 ` NETFILTER_XT_TARGET_NOTRACK Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397131511.25950.97.camel@chaos.site \
    --to=jdelvare@suse.de \
    --cc=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=mkubecek@suse.cz \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).