From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: arturo.borrero.glez@gmail.com, netfilter-devel@vger.kernel.org
Subject: [PATCH 0/2] nftables: fix big endian bugs
Date: Sat, 12 Apr 2014 11:09:57 +0200 [thread overview]
Message-ID: <1397293799-2600-1-git-send-email-kaber@trash.net> (raw)
The following two patches fix the remaining big endian bugs in nftables
I could find during my testing.
Patch 1 addresses the problem that a constant expression is allocated with
data from a variable that is larger than the data size. On big endian we
can't simply use &var but need to calculate the address of the data
dependant on the size of the variable and the size of the data we want.
Patch 2 fixes the GMP import/export functions for BYTEORDER_HOST_ENDIAN
to use the proper word order dependant on the host endianess. This is needed
because we always use a word size of 1 and the word order basically
determines the byte order.
With these patches in place, everything appears to work fine. A single
fix for the kernel is also needed, this will be sent seperately.
next reply other threads:[~2014-04-12 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 9:09 Patrick McHardy [this message]
2014-04-12 9:09 ` [PATCH 1/2] expression: fix constant expression allocation on big endian Patrick McHardy
2014-04-12 9:09 ` [PATCH 2/2] gmputil: use MSF/LSF in import/export functions dependant on host byte order Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397293799-2600-1-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).