From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH nft] parser: use symbolic expression for ether too
Date: Wed, 28 May 2014 10:06:16 +0200 [thread overview]
Message-ID: <1401264376-4094-1-git-send-email-pablo@netfilter.org> (raw)
Like in 0dbced3 ("parser: use symbolic expressions for parsing
keywords as protocol values"), convert `ether' to use a symbolic
expression.
This fixes:
# nft add rule ip filter input meta iiftype ether
# nft list table filter
table ip filter {
...
iiftype 256
which was converted to network byte order.
Reported-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/parser.y | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/parser.y b/src/parser.y
index 20a836e..38b655d 100644
--- a/src/parser.y
+++ b/src/parser.y
@@ -1848,10 +1848,9 @@ eth_hdr_expr : ETHER eth_hdr_field
}
| ETHER
{
- uint16_t data = ARPHRD_ETHER;
- $$ = constant_expr_alloc(&@$, &arphrd_type,
- BYTEORDER_BIG_ENDIAN,
- sizeof(data) * BITS_PER_BYTE, &data);
+ $$ = symbol_expr_alloc(&@$, SYMBOL_VALUE,
+ current_scope(state),
+ "ether");
}
;
--
1.7.10.4
reply other threads:[~2014-05-28 8:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401264376-4094-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).