netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH nft] parser: use symbolic expression for ether too
@ 2014-05-28  8:06 Pablo Neira Ayuso
  0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2014-05-28  8:06 UTC (permalink / raw)
  To: netfilter-devel; +Cc: kaber

Like in 0dbced3 ("parser: use symbolic expressions for parsing
keywords as protocol values"), convert `ether' to use a symbolic
expression.

This fixes:

 # nft add rule ip filter input meta iiftype ether
 # nft list table filter
 table ip filter {
	...
	iiftype 256

which was converted to network byte order.

Reported-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 src/parser.y |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/parser.y b/src/parser.y
index 20a836e..38b655d 100644
--- a/src/parser.y
+++ b/src/parser.y
@@ -1848,10 +1848,9 @@ eth_hdr_expr		:	ETHER	eth_hdr_field
 			}
 			|	ETHER
 			{
-				uint16_t data = ARPHRD_ETHER;
-				$$ = constant_expr_alloc(&@$, &arphrd_type,
-							 BYTEORDER_BIG_ENDIAN,
-							 sizeof(data) * BITS_PER_BYTE, &data);
+				$$ = symbol_expr_alloc(&@$, SYMBOL_VALUE,
+						       current_scope(state),
+						       "ether");
 			}
 			;
 
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-05-28  8:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28  8:06 [PATCH nft] parser: use symbolic expression for ether too Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).