From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 5/5] expr: reject: Do not print unset values in json
Date: Wed, 4 Jun 2014 13:38:11 +0200 [thread overview]
Message-ID: <1401881891-4990-6-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1401881891-4990-1-git-send-email-anarey@gmail.com>
It changes the parse and the snprint functions to omit unset values.
If It uses this rule:
nft add rule ip test output input
It gets this json file:
[...] "expr":[{"type":"reject","type":0,"code":0}]}
Now, That rule creates this json file without null values:
[...] "expr":[{"type":"reject"}]}
Signed-off-by: Ana Rey <anarey@gmail.com>
---
src/expr/reject.c | 31 ++++++++++++++++++++-----------
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/src/expr/reject.c b/src/expr/reject.c
index 8fc99af..39de634 100644
--- a/src/expr/reject.c
+++ b/src/expr/reject.c
@@ -130,15 +130,11 @@ nft_rule_expr_reject_json_parse(struct nft_rule_expr *e, json_t *root,
uint32_t type;
uint8_t code;
- if (nft_jansson_parse_val(root, "type", NFT_TYPE_U32, &type, err) < 0)
- return -1;
-
- nft_rule_expr_set_u32(e, NFT_EXPR_REJECT_TYPE, type);
-
- if (nft_jansson_parse_val(root, "code", NFT_TYPE_U8, &code, err) < 0)
- return -1;
+ if (nft_jansson_parse_val(root, "type", NFT_TYPE_U32, &type, err) == 0)
+ nft_rule_expr_set_u32(e, NFT_EXPR_REJECT_TYPE, type);
- nft_rule_expr_set_u8(e, NFT_EXPR_REJECT_CODE, code);
+ if (nft_jansson_parse_val(root, "code", NFT_TYPE_U8, &code, err) == 0)
+ nft_rule_expr_set_u8(e, NFT_EXPR_REJECT_CODE, code);
return 0;
#else
@@ -203,11 +199,24 @@ static int nft_rule_expr_reject_snprintf_xml(char *buf, size_t len,
static int nft_rule_expr_reject_snprintf_json(char *buf, size_t len,
struct nft_rule_expr *e)
{
+ int ret, size = len, offset = 0;
struct nft_expr_reject *reject = nft_expr_data(e);
- return snprintf(buf, len, "\"type\":%u,"
- "\"code\":%u,",
- reject->type, reject->icmp_code);
+ if (e->flags & (1 << NFT_EXPR_REJECT_TYPE)) {
+ ret = snprintf(buf+offset, len, "\"type\":%u,",
+ reject->type);
+ SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
+ }
+ if (e->flags & (1 << NFT_EXPR_REJECT_CODE)) {
+ ret = snprintf(buf+offset, len, "\"code\":%u,",
+ reject->icmp_code);
+ SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
+ }
+
+ if (offset > 0) {
+ return offset-1;
+ }
+ return offset;
}
static int
--
2.0.0.rc2
next prev parent reply other threads:[~2014-06-04 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:38 [libnftnl PATCH 0/5] reject: Do not print unset value Ana Rey
2014-06-04 11:38 ` [libnftnl PATCH 1/5] expr: reject: Add nft_rule_expr_reject_snprinf_* functions Ana Rey
2014-06-05 13:19 ` Pablo Neira Ayuso
2014-06-04 11:38 ` [libnftnl PATCH 2/5] expr: reject: Use nft_rule_expr_set_* in the xml and default parsing code Ana Rey
2014-06-05 13:19 ` Pablo Neira Ayuso
2014-06-04 11:38 ` [libnftnl PATCH 3/5] expr: reject: Do not print unset values in xml Ana Rey
2014-06-05 13:19 ` Pablo Neira Ayuso
2014-06-04 11:38 ` [libnftnl PATCH 4/5] expr: reject: Convert the type of a variable Ana Rey
2014-06-05 13:20 ` Pablo Neira Ayuso
2014-06-04 11:38 ` Ana Rey [this message]
2014-06-05 13:20 ` [libnftnl PATCH 5/5] expr: reject: Do not print unset values in json Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401881891-4990-6-git-send-email-anarey@gmail.com \
--to=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).