From: Yuxuan Shui <yshuiv7@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Yuxuan Shui <yshuiv7@gmail.com>
Subject: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
Date: Thu, 5 Jun 2014 22:19:16 +0800 [thread overview]
Message-ID: <1401977956-15500-3-git-send-email-yshuiv7@gmail.com> (raw)
In-Reply-To: <1401977956-15500-1-git-send-email-yshuiv7@gmail.com>
Add SKPID and SKSID meta keys so we can implement PID and SID matching
rules in userspace nft tool.
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
include/uapi/linux/netfilter/nf_tables.h | 4 ++++
net/netfilter/nft_meta.c | 25 +++++++++++++++++++++++++
2 files changed, 29 insertions(+)
diff --git a/include/uapi/linux/netfilter/nf_tables.h b/include/uapi/linux/netfilter/nf_tables.h
index 7d6433f..d41880f 100644
--- a/include/uapi/linux/netfilter/nf_tables.h
+++ b/include/uapi/linux/netfilter/nf_tables.h
@@ -565,6 +565,8 @@ enum nft_exthdr_attributes {
* @NFT_META_L4PROTO: layer 4 protocol number
* @NFT_META_BRI_IIFNAME: packet input bridge interface name
* @NFT_META_BRI_OIFNAME: packet output bridge interface name
+ * @NFT_META_SKPID: origination socket owner PID
+ * @NFT_META_SKSID: origination socket owner SID
*/
enum nft_meta_keys {
NFT_META_LEN,
@@ -586,6 +588,8 @@ enum nft_meta_keys {
NFT_META_L4PROTO,
NFT_META_BRI_IIFNAME,
NFT_META_BRI_OIFNAME,
+ NFT_META_SKPID,
+ NFT_META_SKSID,
};
/**
diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 852b178..777ed53 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -14,6 +14,7 @@
#include <linux/netlink.h>
#include <linux/netfilter.h>
#include <linux/netfilter/nf_tables.h>
+#include <linux/pid.h>
#include <net/dst.h>
#include <net/sock.h>
#include <net/tcp_states.h> /* for TCP_TIME_WAIT */
@@ -27,6 +28,8 @@ void nft_meta_get_eval(const struct nft_expr *expr,
const struct nft_meta *priv = nft_expr_priv(expr);
const struct sk_buff *skb = pkt->skb;
const struct net_device *in = pkt->in, *out = pkt->out;
+ const struct task_struct *task;
+ const struct pid *sid;
struct nft_data *dest = &data[priv->dreg];
switch (priv->key) {
@@ -109,6 +112,26 @@ void nft_meta_get_eval(const struct nft_expr *expr,
skb->sk->sk_socket->file->f_cred->fsgid);
read_unlock_bh(&skb->sk->sk_callback_lock);
break;
+ case NFT_META_SKPID:
+ if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
+ goto err;
+
+ read_lock_bh(&skb->sk->sk_callback_lock);
+ dest->data[0] = pid_nr(skb->sk->sk_peer_pid);
+ read_unlock_bh(&skb->sk->sk_callback_lock);
+ break;
+ case NFT_META_SKSID:
+ if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
+ goto err;
+
+ read_lock_bh(&skb->sk->sk_callback_lock);
+ task = get_pid_task(skb->sk->sk_peer_pid, PIDTYPE_PID);
+ sid = task_session(task);
+ if (!sid)
+ goto err;
+ dest->data[0] = pid_nr(sid);
+ read_unlock_bh(&skb->sk->sk_callback_lock);
+ break;
#ifdef CONFIG_IP_ROUTE_CLASSID
case NFT_META_RTCLASSID: {
const struct dst_entry *dst = skb_dst(skb);
@@ -189,6 +212,8 @@ int nft_meta_get_init(const struct nft_ctx *ctx,
case NFT_META_OIFTYPE:
case NFT_META_SKUID:
case NFT_META_SKGID:
+ case NFT_META_PID:
+ case NFT_META_SID:
#ifdef CONFIG_IP_ROUTE_CLASSID
case NFT_META_RTCLASSID:
#endif
--
1.9.3
next prev parent reply other threads:[~2014-06-05 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 14:19 [PATCH nftables 1/3] meta: Add support for SKPID and SKSID meta keys Yuxuan Shui
2014-06-05 14:19 ` [PATCH libnftnl 2/3] " Yuxuan Shui
2014-06-05 14:19 ` Yuxuan Shui [this message]
2014-06-05 14:25 ` [PATCH 3/3] netfilter: Add " Florian Westphal
2014-06-10 11:01 ` Pablo Neira Ayuso
2014-06-19 10:16 ` Tomasz Bursztyka
2014-06-19 10:19 ` Pablo Neira Ayuso
2014-06-19 10:25 ` Tomasz Bursztyka
2014-06-21 14:40 ` [PATCH v2] " Yuxuan Shui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401977956-15500-3-git-send-email-yshuiv7@gmail.com \
--to=yshuiv7@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).