From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 3/4] expr: limit: Do not print unset values in json
Date: Mon, 16 Jun 2014 11:10:16 +0200 [thread overview]
Message-ID: <1402909817-25325-4-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1402909817-25325-1-git-send-email-anarey@gmail.com>
It changes the parse and the snprint functions to omit unset values.
Now, This part of a json file is gotten without unset elements.
{"expr":[{"type":"limit","rate":400,"unit":60}]}
Signed-off-by: Ana Rey <anarey@gmail.com>
---
src/expr/limit.c | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/src/expr/limit.c b/src/expr/limit.c
index 6e0a732..6732318 100644
--- a/src/expr/limit.c
+++ b/src/expr/limit.c
@@ -124,15 +124,11 @@ static int nft_rule_expr_limit_json_parse(struct nft_rule_expr *e, json_t *root,
#ifdef JSON_PARSING
uint64_t uval64;
- if (nft_jansson_parse_val(root, "rate", NFT_TYPE_U64, &uval64, err) < 0)
- return -1;
-
- nft_rule_expr_set_u64(e, NFT_EXPR_LIMIT_RATE, uval64);
+ if (nft_jansson_parse_val(root, "rate", NFT_TYPE_U64, &uval64, err) == 0)
+ nft_rule_expr_set_u64(e, NFT_EXPR_LIMIT_RATE, uval64);
- if (nft_jansson_parse_val(root, "unit", NFT_TYPE_U64, &uval64, err) < 0)
- return -1;
-
- nft_rule_expr_set_u64(e, NFT_EXPR_LIMIT_UNIT, uval64);
+ if (nft_jansson_parse_val(root, "unit", NFT_TYPE_U64, &uval64, err) == 0)
+ nft_rule_expr_set_u64(e, NFT_EXPR_LIMIT_UNIT, uval64);
return 0;
#else
@@ -191,10 +187,24 @@ static int nft_rule_expr_limit_snprintf_xml(char *buf, size_t len,
static int nft_rule_expr_limit_snprintf_json(char *buf, size_t len,
struct nft_rule_expr *e) {
struct nft_expr_limit *limit = nft_expr_data(e);
+ int ret, size = len, offset = 0;
- return snprintf(buf, len, "\"rate\":%"PRIu64","
- "\"unit\":%"PRIu64"",
- limit->rate, limit->unit);
+ if (e->flags & (1 << NFT_EXPR_LIMIT_RATE)) {
+ ret = snprintf(buf + offset, len, "\"rate\":%"PRIu64",",
+ limit->rate);
+ SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
+ }
+ if (e->flags & (1 << NFT_EXPR_LIMIT_UNIT)) {
+ ret = snprintf(buf + offset, len, "\"unit\":%"PRIu64",",
+ limit->unit);
+ SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
+ }
+
+ /* Remove the last comma characther */
+ if (offset > 0)
+ offset--;
+
+ return offset;
}
static int nft_rule_expr_limit_snprintf_default(char *buf, size_t len,
--
2.0.0
next prev parent reply other threads:[~2014-06-16 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 9:10 [libnftnl PATCH 0/4] limit: Do not print unset value Ana Rey
2014-06-16 9:10 ` [libnftnl PATCH 1/4] expr: limit: Add nft_rule_expr_limit_snprinf_* functions Ana Rey
2014-06-16 9:10 ` [libnftnl PATCH 2/4] expr: limit: Use nft_rule_expr_set_* in the xml parsing code Ana Rey
2014-06-16 9:10 ` Ana Rey [this message]
2014-06-16 9:10 ` [libnftnl PATCH 4/4] expr: limit: Do not print unset values in xml Ana Rey
2014-06-16 10:34 ` [libnftnl PATCH 0/4] limit: Do not print unset value Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402909817-25325-4-git-send-email-anarey@gmail.com \
--to=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).