From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 1/3] expr: bitwise: Get a nft_rule_expr type in nft_rule_expr_bitwise_snprintf_* functions
Date: Thu, 19 Jun 2014 12:05:37 +0200 [thread overview]
Message-ID: <1403172339-29786-2-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1403172339-29786-1-git-send-email-anarey@gmail.com>
Code refactoring in nft_rule_expr_bitwise_snprintf_* functions to get a
nft_rule_expr type instead of nft_expr_bitwise type.
Signed-off-by: Ana Rey <anarey@gmail.com>
---
src/expr/bitwise.c | 27 ++++++++++++---------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/src/expr/bitwise.c b/src/expr/bitwise.c
index c8fd0ec..148ee08 100644
--- a/src/expr/bitwise.c
+++ b/src/expr/bitwise.c
@@ -279,11 +279,11 @@ nft_rule_expr_bitwise_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
#endif
}
-static int
-nft_rule_expr_bitwise_snprintf_json(char *buf, size_t size,
- struct nft_expr_bitwise *bitwise)
+static int nft_rule_expr_bitwise_snprintf_json(char *buf, size_t size,
+ struct nft_rule_expr *e)
{
int len = size, offset = 0, ret;
+ struct nft_expr_bitwise *bitwise = nft_expr_data(e);
ret = snprintf(buf, len, "\"sreg\":%u,"
"\"dreg\":%u,"
@@ -311,10 +311,10 @@ nft_rule_expr_bitwise_snprintf_json(char *buf, size_t size,
return offset;
}
-static int
-nft_rule_expr_bitwise_snprintf_xml(char *buf, size_t size,
- struct nft_expr_bitwise *bitwise)
+static int nft_rule_expr_bitwise_snprintf_xml(char *buf, size_t size,
+ struct nft_rule_expr *e)
{
+ struct nft_expr_bitwise *bitwise = nft_expr_data(e);
int len = size, offset = 0, ret;
ret = snprintf(buf, len, "<sreg>%u</sreg>"
@@ -343,10 +343,10 @@ nft_rule_expr_bitwise_snprintf_xml(char *buf, size_t size,
return offset;
}
-static int
-nft_rule_expr_bitwise_snprintf_default(char *buf, size_t size,
- struct nft_expr_bitwise *bitwise)
+static int nft_rule_expr_bitwise_snprintf_default(char *buf, size_t size,
+ struct nft_rule_expr *e)
{
+ struct nft_expr_bitwise *bitwise = nft_expr_data(e);
int len = size, offset = 0, ret;
ret = snprintf(buf, len, "reg %u = (reg=%u & ",
@@ -371,16 +371,13 @@ static int
nft_rule_expr_bitwise_snprintf(char *buf, size_t size, uint32_t type,
uint32_t flags, struct nft_rule_expr *e)
{
- struct nft_expr_bitwise *bitwise = nft_expr_data(e);
-
switch(type) {
case NFT_OUTPUT_DEFAULT:
- return nft_rule_expr_bitwise_snprintf_default(buf, size,
- bitwise);
+ return nft_rule_expr_bitwise_snprintf_default(buf, size, e);
case NFT_OUTPUT_XML:
- return nft_rule_expr_bitwise_snprintf_xml(buf, size, bitwise);
+ return nft_rule_expr_bitwise_snprintf_xml(buf, size, e);
case NFT_OUTPUT_JSON:
- return nft_rule_expr_bitwise_snprintf_json(buf, size, bitwise);
+ return nft_rule_expr_bitwise_snprintf_json(buf, size, e);
default:
break;
}
--
2.0.0
next prev parent reply other threads:[~2014-06-19 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 10:05 [libnftnl PATCH 0/3] expr: bitwise: Do not print unset values Ana Rey
2014-06-19 10:05 ` Ana Rey [this message]
2014-06-19 10:05 ` [libnftnl PATCH 2/3] expr: bitwise: Do not print unset values in xml Ana Rey
2014-06-19 10:05 ` [libnftnl PATCH 3/3] expr: bitwise: Do not print unset values in json Ana Rey
2014-06-20 7:19 ` [libnftnl PATCH 0/3] expr: bitwise: Do not print unset values Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403172339-29786-2-git-send-email-anarey@gmail.com \
--to=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).