From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 1/3] expr: immediate: Use nft_rule_expr_set_* in the xml parsing code
Date: Sat, 21 Jun 2014 17:53:41 +0200 [thread overview]
Message-ID: <1403366023-6385-2-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1403366023-6385-1-git-send-email-anarey@gmail.com>
Code refactoring to use nft_rule_expr_set_* in parse functions.
Signed-off-by: Ana Rey <anarey@gmail.com>
---
src/expr/immediate.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/expr/immediate.c b/src/expr/immediate.c
index 2ea4636..eab1497 100644
--- a/src/expr/immediate.c
+++ b/src/expr/immediate.c
@@ -229,9 +229,7 @@ nft_rule_expr_immediate_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
if (nft_mxml_reg_parse(tree, "dreg", ®, MXML_DESCEND_FIRST,
NFT_XML_MAND, err) != 0)
return -1;
-
- imm->dreg = reg;
- e->flags |= (1 << NFT_EXPR_IMM_DREG);
+ nft_rule_expr_set_u32(e, NFT_EXPR_IMM_DREG, reg);
datareg_type = nft_mxml_data_reg_parse(tree, "immediatedata",
&imm->data, NFT_XML_MAND, err);
--
2.0.0
next prev parent reply other threads:[~2014-06-21 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 15:53 [libnftnl PATCH 0/3] expr: immediate: Do not print unset values in xml and json Ana Rey
2014-06-21 15:53 ` Ana Rey [this message]
2014-06-21 15:53 ` [libnftnl PATCH 2/3] expr: immediate: Do not print unset values in json file Ana Rey
2014-06-21 15:53 ` [libnftnl PATCH 3/3] expr: immediate: Do not print unset values in xml file Ana Rey
2014-06-23 9:02 ` [libnftnl PATCH 0/3] expr: immediate: Do not print unset values in xml and json Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403366023-6385-2-git-send-email-anarey@gmail.com \
--to=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).