From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 2/4] expr: payload: get a nft_rule_expr type in nft_rule_expr_payload_snprintf_* functions.
Date: Sun, 22 Jun 2014 20:32:19 +0200 [thread overview]
Message-ID: <1403461941-21605-3-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1403461941-21605-1-git-send-email-anarey@gmail.com>
Code refactoring in nft_rule_expr_payload_snprintf_* functions to get a
nft_rule_expr type instead of nft_expr_payload type. The nft_rule_expr is
needed to check information into flags variables.
Moreover, It remanes a variable from 'p' to 'payload' for code
readability reasons.
Signed-off-by: Ana Rey <anarey@gmail.com>
---
src/expr/payload.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/expr/payload.c b/src/expr/payload.c
index 90322c1..6c08e48 100644
--- a/src/expr/payload.c
+++ b/src/expr/payload.c
@@ -165,15 +165,17 @@ static const char *base2str(enum nft_payload_bases base)
static int
nft_rule_expr_payload_snprintf_json(char *buf, size_t len, uint32_t flags,
- struct nft_expr_payload *p)
+ struct nft_rule_expr *e)
{
+ struct nft_expr_payload *payload = nft_expr_data(e);
int size = len, offset = 0, ret;
ret = snprintf(buf, len, "\"dreg\":%u,"
"\"offset\":%u,"
"\"len\":%u,"
"\"base\":\"%s\"",
- p->dreg, p->offset, p->len, base2str(p->base));
+ payload->dreg, payload->offset, payload->len,
+ base2str(payload->base));
SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
return offset;
@@ -281,15 +283,17 @@ nft_rule_expr_payload_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
static int
nft_rule_expr_payload_snprintf_xml(char *buf, size_t len, uint32_t flags,
- struct nft_expr_payload *p)
+ struct nft_rule_expr *e)
{
+ struct nft_expr_payload *payload = nft_expr_data(e);
int size = len, offset = 0, ret;
ret = snprintf(buf, len, "<dreg>%u</dreg>"
"<offset>%u</offset>"
"<len>%u</len>"
"<base>%s</base>",
- p->dreg, p->offset, p->len, base2str(p->base));
+ payload->dreg, payload->offset, payload->len,
+ base2str(payload->base));
SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
return offset;
@@ -307,11 +311,9 @@ nft_rule_expr_payload_snprintf(char *buf, size_t len, uint32_t type,
payload->len, base2str(payload->base),
payload->offset, payload->dreg);
case NFT_OUTPUT_XML:
- return nft_rule_expr_payload_snprintf_xml(buf, len, flags,
- payload);
+ return nft_rule_expr_payload_snprintf_xml(buf, len, flags, e);
case NFT_OUTPUT_JSON:
- return nft_rule_expr_payload_snprintf_json(buf, len, flags,
- payload);
+ return nft_rule_expr_payload_snprintf_json(buf, len, flags, e);
default:
break;
}
--
2.0.0
next prev parent reply other threads:[~2014-06-22 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 18:32 [libnftnl PATCH 0/4] expr: payload: Do not print unset values in xml and json Ana Rey
2014-06-22 18:32 ` [libnftnl PATCH 1/4] expr: payload: Use nft_rule_expr_set_* in the xml parsing code Ana Rey
2014-06-22 18:32 ` Ana Rey [this message]
2014-06-22 18:32 ` [libnftnl PATCH 3/4] expr: payload: Do not print unset values in xml file Ana Rey
2014-06-22 18:32 ` [libnftnl PATCH 4/4] expr: payload: Do not print unset values in json file Ana Rey
2014-06-23 9:15 ` [libnftnl PATCH 0/4] expr: payload: Do not print unset values in xml and json Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403461941-21605-3-git-send-email-anarey@gmail.com \
--to=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).